Skip to content

Conversation

Sanjai-Shaarugesh
Copy link

🏷️ Enhanced Stop Details with Interactive Map

  • Improved stop details for better clarity

  • Integrated interactive Map for a visual experience

  • Added location pointer for precise positioning

  • No embedded map used

image

image

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst

what's about this bro

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst

#239

What's this about? Is this okay now?

This would be helpful to add to my GSoC proposal if it gets merged.

@Sanjai-Shaarugesh
Copy link
Author

Sanjai-Shaarugesh commented Apr 9, 2025

@aaronbrethorst

I have submitted my GSOC proposal this copy of that

wayfinder.pdf

please select me

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst

review my PR please

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature doesn't make any sense on the main map view. It does make sense on the standalone map page, but you're not using the same map view that is in use on the rest of the site. see the rest of my comments for more.

@Sanjai-Shaarugesh
Copy link
Author

Is this okay now

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst

review my PR bro please

@aaronbrethorst
Copy link
Member

@Sanjai-Shaarugesh it's still not ok. I wish you would have asked for input before spending so much of both of our time.

@coveralls
Copy link

Coverage Status

coverage: 14.637% (-1.5%) from 16.097%
when pulling c2cb4cd on Sanjai-Shaarugesh:issue-#204
into d4b0cd3 on OneBusAway:main.

@Sanjai-Shaarugesh
Copy link
Author

Sanjai-Shaarugesh commented Apr 23, 2025

@aaronbrethorst

Could you please explain what I need to do for this?

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst
Please reply

@aaronbrethorst
Copy link
Member

My dude, I have invested a lot of time giving you feedback, and I am deeply disappointed that you haven't tried to really incorporate that feedback into your work. It feels like a drive-by chatgpt effort and doesn't give me any sense of confidence that you are committed to working on onebusaway in any sort of meaningful way. I recommend thinking about applying to fewer organizations and spending more time on each proposal in the future.

@Sanjai-Shaarugesh
Copy link
Author

@aaronbrethorst

no it's not chatgpt's works, i spend lot of effort to work in this feature bro

@aaronbrethorst
Copy link
Member

Sanjai - Please take this feedback to heart: consider the fact that every PR I could find in your recent activity has been closed for basically the same reason. Think about why this might be, how your work is being perceived by the OSS maintainers you are engaging with, and whether this is how you want to comport yourself in a professional setting in the years to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants