-
Notifications
You must be signed in to change notification settings - Fork 29
Enhance Stop Details with Interactive Map Background 🗺️ #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
what's about this bro |
What's this about? Is this okay now?This would be helpful to add to my GSoC proposal if it gets merged. |
I have submitted my GSOC proposal this copy of thatplease select me |
review my PR please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feature doesn't make any sense on the main map view. It does make sense on the standalone map page, but you're not using the same map view that is in use on the rest of the site. see the rest of my comments for more.
cc0f3e1
to
0c913a9
Compare
Is this okay now |
review my PR bro please |
@Sanjai-Shaarugesh it's still not ok. I wish you would have asked for input before spending so much of both of our time. |
Could you please explain what I need to do for this? |
@aaronbrethorst |
My dude, I have invested a lot of time giving you feedback, and I am deeply disappointed that you haven't tried to really incorporate that feedback into your work. It feels like a drive-by chatgpt effort and doesn't give me any sense of confidence that you are committed to working on onebusaway in any sort of meaningful way. I recommend thinking about applying to fewer organizations and spending more time on each proposal in the future. |
no it's not chatgpt's works, i spend lot of effort to work in this feature bro |
Sanjai - Please take this feedback to heart: consider the fact that every PR I could find in your recent activity has been closed for basically the same reason. Think about why this might be, how your work is being perceived by the OSS maintainers you are engaging with, and whether this is how you want to comport yourself in a professional setting in the years to come. |
🏷️ Enhanced Stop Details with Interactive Map
Improved stop details for better clarity
Integrated interactive Map for a visual experience
Added location pointer for precise positioning
No embedded map used