fix(perps): android token scroll tap, share dialog scope, desktop chart expand(OK-52513,OK-52302,OK-52078) by Minnzen · Pull Request #11087 · OneKeyHQ/app-monorepo

Minnzen · 2026-04-07T13:46:57Z

Summary

Fix Android bottom scroll tap in perps token selector
Fix share prompt dialog appearing outside Perps tab
Add desktop chart expand/fullscreen toggle via TradingView header button

Intent & Context

Three perps-related issues addressed in one PR:

OK-52513: Android users couldn't tap tokens when scrolled to the bottom of the selector list — classic nested scroll touch interception on Android
OK-52302: The referral share prompt dialog was appearing even when users navigated away from the Perps tab, because the focus check only tracked "has ever been focused" rather than "is currently focused"
OK-52078: Desktop perps chart needs an expand/fullscreen mode that hides OrderBook, TradingPanel, and bottom panels to give the TradingView chart full screen space

Root Cause

OK-52513: FlashList inside a modal on Android — parent scroll view intercepted touch events at scroll boundaries
OK-52302: hasBeenFocusedRef was a one-time flag (set to true on first Perps visit, never reset). When tradesData updated while user was on another tab, checkAndShowPrompt() ran and showed the dialog globally via Dialog.show()

Design Decisions

Android scroll fix: Used nestedScrollEnabled={platformEnv.isNativeAndroid} — the established pattern across the codebase (DeFiContainer, PortfolioContainer, etc.)
Share dialog fix: Added isFocusedRef for real-time tab focus tracking alongside existing hasBeenFocusedRef. When not focused, sets pendingCheckRef = true so the check retries on next tab focus
Chart expand: Uses display: 'none' instead of conditional rendering (null) to hide panels — preserves component state (order form inputs, WebSocket connections, scroll positions) during expand/collapse. Version-gated to appVersion >= 6.2.0 on the TradingView side
Chart expand state: Reset chartExpanded to false on layout mount to avoid desync between persisted atom state and iframe state after app restart

Changes Detail

File	Purpose
`MoblieTokenSelector.tsx`	Add `nestedScrollEnabled` for Android
`usePerpsSharePrompt.tsx`	Add `isFocusedRef` + pending mechanism for tab-aware dialog
`perps.ts`	Add `chartExpanded` to layout state atom
`messageTypes.ts`	Add `CHART_EXPAND` message constant
`usePerpsTradingViewMessageHandler.ts`	Handle `tradingview_chartExpand` message from iframe
`PerpDesktopLayout.web.tsx`	Toggle panel visibility with `display:none`, reset state on mount
`PerpDesktopLayout.tsx`	Same for non-web desktop, plus `contentContainerStyle` for RN ScrollView

Risk Assessment

Risk Level: Medium
Affected Platforms: Desktop (chart expand), Android (scroll fix), All (share dialog fix)
Risk Areas: Chart expand layout toggle — uses display:none to keep components mounted; TradingView iframe ↔ app state sync relies on message passing

Related PR

TradingView charting library: OneKeyHQ/tradingview-charting-library — feat/chart-expand-button branch (adds ChartExpandManager with version gating)

Test plan

Android: Open perps token selector, scroll to bottom, verify taps register on last items
Desktop: Open Perps, click chart expand button, verify OrderBook/TradingPanel/bottom panels hide and chart fills space
Desktop: Click collapse button, verify all panels restore with preserved state (order form values, scroll positions)
Desktop: Expand chart, switch symbol, verify layout collapses correctly (destroy sends collapse message)
All platforms: Meet share prompt conditions (3+ trades, $100k+ volume), navigate away from Perps tab, verify dialog does NOT appear on other tabs
All platforms: Return to Perps tab after above, verify share dialog appears correctly

…rt expand(OK-52513,OK-52302,OK-52078) - Fix Android bottom scroll tap in token selector by enabling nestedScrollEnabled - Fix share prompt dialog appearing outside Perps tab by tracking real-time focus state - Add desktop chart expand/fullscreen toggle via TradingView header button with version gating (>=6.2.0) - Use display:none instead of unmounting panels to preserve state during expand/collapse

revan-zhang · 2026-04-07T13:47:16Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

socket-security · 2026-04-08T02:22:44Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

…rt expand(OK-52513,OK-52302,OK-52078) (OneKeyHQ#11087) * fix(perps): android token scroll tap, share dialog scope, desktop chart expand(OK-52513,OK-52302,OK-52078) - Fix Android bottom scroll tap in token selector by enabling nestedScrollEnabled - Fix share prompt dialog appearing outside Perps tab by tracking real-time focus state - Add desktop chart expand/fullscreen toggle via TradingView header button with version gating (>=6.2.0) - Use display:none instead of unmounting panels to preserve state during expand/collapse * fix: prettier format for import statement * fix: use functional updater for chartExpanded reset and fix spellcheck * fix: exclude modal-covered state from share prompt focus check * fix: re-check focus after async gap in share prompt * fix: align @stoprocent/noble version to 2.3.10 across desktop packages * fix: update yarn.lock for @stoprocent/noble version alignment --------- Co-authored-by: morizon <sidmorizon@outlook.com> Co-authored-by: huhuanming <huanming@onekey.so>

Minnzen requested review from ezailWang, huhuanming, originalix, revan-zhang and sidmorizon as code owners April 7, 2026 13:46

Minnzen enabled auto-merge (squash) April 7, 2026 13:47

Merge branch 'x' into fix/perps-share-dialog-android-scroll-chart-expand

79556d3

devin-ai-integration Bot reviewed Apr 7, 2026

View reviewed changes

fix: prettier format for import statement

eece39d

This comment was marked as resolved.

Sign in to view

fix: use functional updater for chartExpanded reset and fix spellcheck

f7791b2

originalix previously approved these changes Apr 7, 2026

View reviewed changes

originalix reviewed Apr 7, 2026

View reviewed changes

Comment thread packages/kit/src/views/Perp/hooks/usePerpsSharePrompt.tsx Outdated

originalix reviewed Apr 7, 2026

View reviewed changes

Comment thread packages/kit/src/views/Perp/hooks/usePerpsSharePrompt.tsx

fix: exclude modal-covered state from share prompt focus check

08bc682

Minnzen dismissed originalix’s stale review via 08bc682 April 7, 2026 14:21

Minnzen and others added 2 commits April 7, 2026 22:23

fix: re-check focus after async gap in share prompt

b24a952

Merge branch 'x' into fix/perps-share-dialog-android-scroll-chart-expand

923b461

Minnzen requested a review from originalix April 7, 2026 14:40

originalix previously approved these changes Apr 7, 2026

View reviewed changes

sidmorizon and others added 3 commits April 7, 2026 22:45

Merge branch 'x' into fix/perps-share-dialog-android-scroll-chart-expand

6dda2dc

Merge branch 'x' into fix/perps-share-dialog-android-scroll-chart-expand

209b9a3

fix: align @stoprocent/noble version to 2.3.10 across desktop packages

f4b8ee5

Minnzen dismissed originalix’s stale review via f4b8ee5 April 8, 2026 02:17

fix: update yarn.lock for @stoprocent/noble version alignment

11ac52d

Minnzen requested a review from originalix April 8, 2026 02:40

huhuanming approved these changes Apr 8, 2026

View reviewed changes

Merge branch 'x' into fix/perps-share-dialog-android-scroll-chart-expand

0cbb1aa

limichange approved these changes Apr 8, 2026

View reviewed changes

Minnzen merged commit 0cfddc2 into x Apr 8, 2026
12 checks passed

Minnzen deleted the fix/perps-share-dialog-android-scroll-chart-expand branch April 8, 2026 03:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(perps): android token scroll tap, share dialog scope, desktop chart expand(OK-52513,OK-52302,OK-52078)#11087

fix(perps): android token scroll tap, share dialog scope, desktop chart expand(OK-52513,OK-52302,OK-52078)#11087
Minnzen merged 12 commits into
xfrom
fix/perps-share-dialog-android-scroll-chart-expand

Minnzen commented Apr 7, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

revan-zhang commented Apr 7, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Minnzen commented Apr 7, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Intent & Context

Root Cause

Design Decisions

Changes Detail

Risk Assessment

Related PR

Test plan

Uh oh!

revan-zhang commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Minnzen commented Apr 7, 2026 •

edited by devin-ai-integration Bot

Loading

revan-zhang commented Apr 7, 2026 •

edited

Loading

socket-security Bot commented Apr 8, 2026 •

edited

Loading