chore: adding detekt #2376
Open
chore: adding detekt #2376
+1,190
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulraqeeb33
commented
Oct 9, 2025
|
|
||
| } | ||
|
|
||
| subprojects { |
There was a problem hiding this comment.
this part will ignore the test files and as it doesnt make sense to run detekt on tests.
abdulraqeeb33
commented
Oct 13, 2025
| ignoreAnnotated: ["Inject"] | ||
|
|
||
| UnsafeCallOnNullableType: | ||
| active: true |
There was a problem hiding this comment.
this will help us with catching usage of !!
abdulraqeeb33
commented
Oct 17, 2025
| ignoreNamedArgument: true | ||
|
|
||
| MaxLineLength: | ||
| active: false |
There was a problem hiding this comment.
disabled it here as spotless is able to do the same check
jkasten2
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Integrating detekt into the project
Details
Motivation
Adding Detekt improves code quality and consistency by automatically detecting potential issues and enforcing style guidelines in Kotlin projects.
I will be creating a follow up PR that will basically add detekt as a step in the github action.
Scope
Mostly used for internal purposes. Each module has its own baseline. And all modules share a common detekt config.
As we continue working on this codebase, we will use these rules to block the PR.
Testing
Unit testing
No impact
Manual testing
Tested
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is