Skip to content

chore: adding detekt #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: adding detekt #2376

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d10bdb8
detekt
Oct 9, 2025
f8bf3df
excluding tests
Oct 9, 2025
a3c2f63
add git add build.gradle detekt null check
Oct 13, 2025
c26318d
merging
Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion OneSignalSDK/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ buildscript {
minSdkVersion: 21
]
androidGradlePluginVersion = '8.8.2'
detektVersion = '1.23.8'
googleServicesGradlePluginVersion = '4.3.10'
huaweiAgconnectVersion = '1.9.1.304'
huaweiHMSPushVersion = '6.3.0.304'
Expand All @@ -17,6 +18,7 @@ buildscript {
kotestVersion = '5.8.0'
ktlintPluginVersion = '11.6.1'
ktlintVersion = '1.0.1'
ioMockVersion = '1.13.2'
// DO NOT upgrade for tests, using an old version so it matches AOSP
tdunningJsonForTest = '1.0'

Expand All @@ -33,7 +35,9 @@ buildscript {
"com.huawei.agconnect:agcp:$huaweiAgconnectVersion",
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion",
"org.jlleitschuh.gradle:ktlint-gradle:$ktlintPluginVersion",
"com.vanniktech.maven.publish:com.vanniktech.maven.publish.gradle.plugin:0.32.0"
"com.vanniktech.maven.publish:com.vanniktech.maven.publish.gradle.plugin:0.32.0",
"io.gitlab.arturbosch.detekt:detekt-gradle-plugin:$detektVersion"

]
}

Expand All @@ -55,4 +59,29 @@ allprojects {
// Huawei maven
maven { url 'https://developer.huawei.com/repo/' }
}

}

subprojects {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part will ignore the test files and as it doesnt make sense to run detekt on tests.

plugins.withId("io.gitlab.arturbosch.detekt") {
afterEvaluate {
def configureDetektTask = { task ->
// Only analyze main source sets
task.source = files(
"$projectDir/src/main/java",
"$projectDir/src/main/kotlin"
)
// Exclude all test-related files and directories
task.exclude "**/test/**", "**/androidTest/**", "**/src/test/**", "**/src/androidTest/**",
"**/*Test.kt", "**/*Tests.kt", "**/*Spec.kt",
"**/*Test.java", "**/*Tests.java", "**/*Spec.java"

// Enable type resolution to catch !! operator
task.jvmTarget = "1.8"
}

tasks.withType(io.gitlab.arturbosch.detekt.Detekt).configureEach(configureDetektTask)
tasks.withType(io.gitlab.arturbosch.detekt.DetektCreateBaselineTask).configureEach(configureDetektTask)
}
}
}
810 changes: 810 additions & 0 deletions OneSignalSDK/detekt/detekt-baseline-core.xml
View file
Open in desktop

Large diffs are not rendered by default.

188 changes: 188 additions & 0 deletions OneSignalSDK/detekt/detekt-baseline-in-app-messages.xml
View file
Open in desktop

Large diffs are not rendered by default.

74 changes: 74 additions & 0 deletions OneSignalSDK/detekt/detekt-baseline-location.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController$private val _fusedLocationApiWrapper: IFusedLocationApiWrapper</ID>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController.GoogleApiClientListener$private val _parent: GmsLocationController</ID>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController.LocationUpdateListener$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController.LocationUpdateListener$private val _fusedLocationApiWrapper: IFusedLocationApiWrapper</ID>
<ID>ConstructorParameterNaming:GmsLocationController.kt$GmsLocationController.LocationUpdateListener$private val _parent: GmsLocationController</ID>
<ID>ConstructorParameterNaming:HmsLocationController.kt$HmsLocationController$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:HmsLocationController.kt$HmsLocationController.LocationUpdateListener$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:HmsLocationController.kt$HmsLocationController.LocationUpdateListener$private val _parent: HmsLocationController</ID>
<ID>ConstructorParameterNaming:LocationBackgroundService.kt$LocationBackgroundService$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:LocationBackgroundService.kt$LocationBackgroundService$private val _capturer: ILocationCapturer</ID>
<ID>ConstructorParameterNaming:LocationBackgroundService.kt$LocationBackgroundService$private val _locationManager: ILocationManager</ID>
<ID>ConstructorParameterNaming:LocationBackgroundService.kt$LocationBackgroundService$private val _prefs: ILocationPreferencesService</ID>
<ID>ConstructorParameterNaming:LocationBackgroundService.kt$LocationBackgroundService$private val _time: ITime</ID>
<ID>ConstructorParameterNaming:LocationCapturer.kt$LocationCapturer$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:LocationCapturer.kt$LocationCapturer$private val _controller: ILocationController</ID>
<ID>ConstructorParameterNaming:LocationCapturer.kt$LocationCapturer$private val _prefs: ILocationPreferencesService</ID>
<ID>ConstructorParameterNaming:LocationCapturer.kt$LocationCapturer$private val _propertiesModelStore: PropertiesModelStore</ID>
<ID>ConstructorParameterNaming:LocationCapturer.kt$LocationCapturer$private val _time: ITime</ID>
<ID>ConstructorParameterNaming:LocationManager.kt$LocationManager$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:LocationManager.kt$LocationManager$private val _capturer: ILocationCapturer</ID>
<ID>ConstructorParameterNaming:LocationManager.kt$LocationManager$private val _locationController: ILocationController</ID>
<ID>ConstructorParameterNaming:LocationManager.kt$LocationManager$private val _locationPermissionController: LocationPermissionController</ID>
<ID>ConstructorParameterNaming:LocationManager.kt$LocationManager$private val _prefs: IPreferencesService</ID>
<ID>ConstructorParameterNaming:LocationPermissionController.kt$LocationPermissionController$private val _applicationService: IApplicationService</ID>
<ID>ConstructorParameterNaming:LocationPermissionController.kt$LocationPermissionController$private val _requestPermission: IRequestPermissionService</ID>
<ID>ConstructorParameterNaming:LocationPreferencesService.kt$LocationPreferencesService$private val _prefs: IPreferencesService</ID>
<ID>CyclomaticComplexMethod:LocationManager.kt$LocationManager$override suspend fun requestPermission(): Boolean</ID>
<ID>ForbiddenComment:GmsLocationController.kt$GmsLocationController$// TODO: google api client has a blocking connect with timeout, use that instead of our withTimeout?</ID>
<ID>LongMethod:GmsLocationController.kt$GmsLocationController$override suspend fun start(): Boolean</ID>
<ID>LongMethod:HmsLocationController.kt$HmsLocationController$override suspend fun start(): Boolean</ID>
<ID>LongMethod:LocationManager.kt$LocationManager$override suspend fun requestPermission(): Boolean</ID>
<ID>MagicNumber:GmsLocationController.kt$GmsLocationController.LocationUpdateListener$1.5</ID>
<ID>MagicNumber:HmsLocationController.kt$HmsLocationController.LocationUpdateListener$1.5</ID>
<ID>MagicNumber:LocationBackgroundService.kt$LocationBackgroundService$1000</ID>
<ID>MagicNumber:LocationCapturer.kt$LocationCapturer$7</ID>
<ID>MagicNumber:LocationManager.kt$LocationManager$29</ID>
<ID>MaxLineLength:FusedLocationApiWrapperImpl.kt$FusedLocationApiWrapperImpl$LocationServices.FusedLocationApi.requestLocationUpdates(googleApiClient, locationRequest, locationListener)</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController$"GMSLocationController connection to GoogleApiService failed: (${result?.errorCode}) ${result?.errorMessage}"</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController$"Location permission exists but GoogleApiClient timed out. Maybe related to mismatch google-play aar versions."</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController$// TODO: google api client has a blocking connect with timeout, use that instead of our withTimeout?</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController$self.locationUpdateListener = LocationUpdateListener(_applicationService, self, proxyGoogleApiClient.realInstance, _fusedLocationApiWrapper)</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController.GoogleApiClientListener$Logging.debug("GMSLocationController GoogleApiClientListener onConnectionSuspended connectionResult: $connectionResult")</ID>
<ID>MaxLineLength:GmsLocationController.kt$GmsLocationController.GoogleApiClientListener$private</ID>
<ID>MaxLineLength:HmsLocationController.kt$HmsLocationController$com.huawei.hms.location.LocationServices.getFusedLocationProviderClient(_applicationService.appContext)</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$// If permission already given prompt will return positive, otherwise will prompt again or show settings</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$Logging.warn("Requesting location permission, but location sharing must also be enabled by setting isShared to true")</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$_locationPermissionController.prompt(fallbackToSettings, LocationConstants.ANDROID_BACKGROUND_LOCATION_PERMISSION_STRING)</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$hasBackgroundPermissionGranted = AndroidUtils.hasPermission(LocationConstants.ANDROID_BACKGROUND_LOCATION_PERMISSION_STRING, true, _applicationService)</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$hasCoarsePermissionGranted = AndroidUtils.hasPermission(LocationConstants.ANDROID_COARSE_LOCATION_PERMISSION_STRING, true, _applicationService)</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$private var _isShared: Boolean = _prefs.getBool(PreferenceStores.ONESIGNAL, PreferenceOneSignalKeys.PREFS_OS_LOCATION_SHARED, false)!!</ID>
<ID>MaxLineLength:LocationManager.kt$LocationManager$}</ID>
<ID>MaxLineLength:LocationPermissionController.kt$LocationPermissionController.&lt;no name provided&gt;.&lt;no name provided&gt;$val hasPermission = AndroidUtils.hasPermission(currPermission, true, _applicationService)</ID>
<ID>MaxLineLength:LocationUtils.kt$LocationUtils$ContextCompat.checkSelfPermission(context, "android.permission.ACCESS_COARSE_LOCATION") === PackageManager.PERMISSION_GRANTED</ID>
<ID>MaxLineLength:LocationUtils.kt$LocationUtils$ContextCompat.checkSelfPermission(context, "android.permission.ACCESS_FINE_LOCATION") === PackageManager.PERMISSION_GRANTED</ID>
<ID>MayBeConst:GmsLocationController.kt$GmsLocationController.Companion$val API_FALLBACK_TIME = 30000</ID>
<ID>PrintStackTrace:GoogleApiClientCompatProxy.kt$GoogleApiClientCompatProxy$t</ID>
<ID>ProtectedMemberInFinalClass:GmsLocationController.kt$GmsLocationController$LocationHandlerThread : HandlerThread</ID>
<ID>SwallowedException:GmsLocationController.kt$GmsLocationController$e: TimeoutCancellationException</ID>
<ID>SwallowedException:LocationUtils.kt$LocationUtils$e: NoClassDefFoundError</ID>
<ID>TooGenericExceptionCaught:FusedLocationApiWrapperImpl.kt$FusedLocationApiWrapperImpl$t: Throwable</ID>
<ID>TooGenericExceptionCaught:GoogleApiClientCompatProxy.kt$GoogleApiClientCompatProxy$t: Throwable</ID>
<ID>TooGenericExceptionCaught:HmsLocationController.kt$HmsLocationController$e: Exception</ID>
<ID>TooGenericExceptionCaught:LocationManager.kt$LocationManager$t: Throwable</ID>
<ID>TooGenericExceptionThrown:GmsLocationController.kt$GmsLocationController.LocationUpdateListener$throw Exception("googleApiClient not connected, cannot listen!")</ID>
<ID>UndocumentedPublicClass:ShadowGoogleApiClient.kt$ShadowGoogleApiClient : GoogleApiClient</ID>
<ID>UndocumentedPublicClass:ShadowGoogleApiClient.kt$ShadowGoogleApiClient$Companion</ID>
<ID>UndocumentedPublicClass:ShadowGoogleApiClient.kt$ShadowGoogleApiClientBuilder</ID>
</CurrentIssues>
</SmellBaseline>
Loading
Loading