Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Oct 23, 2025

Description

One Line Summary

Add this test class, that was created in #2382

Details

Motivation

Add testing coverage. This class was originally meant to test #2378 but the implementation was changed, but let's still keep relevant test case.

Scope

Tests

Testing

Unit testing

Adds SessionListenerTests

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@nan-li nan-li changed the base branch from main to feat/update_timezone October 23, 2025 22:50
@nan-li nan-li requested a review from abdulraqeeb33 October 23, 2025 22:51
@nan-li nan-li force-pushed the chore/add_session_listener_tests branch from 891819f to 6b7c84b Compare October 24, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant