Skip to content

DROPPED - Revert/5.4.0 changes#2415

Closed
jkasten2 wants to merge 3 commits intomainfrom
revert/5.4.0-changes
Closed

DROPPED - Revert/5.4.0 changes#2415
jkasten2 wants to merge 3 commits intomainfrom
revert/5.4.0-changes

Conversation

@jkasten2
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 commented Nov 18, 2025

git revert was used in this PR to rollback changes temporary made for 5.4.0, however is not a good approach in this case.

  • This PR breaks the build and we don't want to rollback the CI/CD improvements we also made on main (such as lint checks) nor make one off commits for a temporary rollback.

Instead of this PR, a 5.4.1 release was made on top of the 5.1.38 tag to do the same rollback effect.

  • This way we can focus on moving forward with main being latest, apply fixes to it, and releasing 5.4.2 once all fixes are ready.

This change is Reviewable

@michael-winkler
Copy link
Copy Markdown

michael-winkler commented Nov 18, 2025

A description explaining why this is not consistent is missing..

PS:
It might be time to look into joining an initiative.

@jkasten2
Copy link
Copy Markdown
Member Author

git revert was used in this PR to rollback changes temporary made for 5.4.0, however is not a good approach in this case.

  • This PR breaks the build and we don't want to rollback the CI/CD improvements we also made on main (such as lint checks) nor make one off commits for a temporary rollback.

Instead of this PR, a 5.4.1 release was made on top of the 5.1.38 tag to do the same rollback effect.

  • This way we can focus on moving forward with main being latest, apply fixes to it, and releasing 5.4.2 once all fixes are ready.

@jkasten2 jkasten2 closed this Nov 18, 2025
@jkasten2 jkasten2 changed the title WIP - Revert/5.4.0 changes DROPPED - Revert/5.4.0 changes Nov 18, 2025
@jkasten2 jkasten2 deleted the revert/5.4.0-changes branch November 20, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants