feat: tel crash reporting

[abdulraqeeb33]

Description

One Line Summary

Logging, Crash handling using Otel

Details

Motivation

We want to be able to capture logs, crashes and ANRs - report them to our servers so that we can inspect and fix them on devices.

Scope

Major Architectural Changes and Improvements from this implementation PR

1. Platform-Agnostic Design & Dependency Reduction

• Created OtelIdResolver - Reads OneSignal IDs directly from SharedPreferences (no service dependencies)
• Refactored OtelPlatformProvider - Uses OtelIdResolver internally, removing all service dependencies
• Created factory function createAndroidOtelPlatformProvider(context) - Single parameter, no services needed
• Removed service dependencies from initializeOtelLogging() - No longer needs IInstallIdService, ConfigModelStore, IdentityModelStore

2. Initialization Consolidation

• Converted OneSignalCrashLogInit from object to class - Manages platform provider lifecycle as instance variable
• Platform provider created once and reused - Single instance used for both crash handler and logging initialization
• Early crash handler initialization - Initialized before other services to capture all crashes

3. Component Simplification

• OneSignalCrashHandlerFactory - Simplified to only need Context and IOtelLogger
• OtelFactory.createCrashHandler - Refactored to compose other factory methods, reducing duplication

Code Organization & Centralization

4. Constants & Utilities

• Created AnrConstants.kt - Centralized DEFAULT_ANR_THRESHOLD_MS and DEFAULT_CHECK_INTERVAL_MS
• Centralized isOneSignalAtFault() logic - Moved to OtelCrashHandler.kt (shared by crash handler and ANR detector)
• Renamed constants - CONFIG_NAME_SPACE, IDENTITY_NAME_SPACE to match naming conventions (updated 77 usages across 8 files)

5. Code Quality Improvements

• Extracted helper methods in OtelAnrDetector - Reduced complexity (LongMethod, NestedBlockDepth)
• Fixed all detekt issues - Added appropriate @Suppress annotations where needed
• Improved exception handling - More specific exception types where appropriate

Test Coverage & Reliability

6. Comprehensive Test Suite

• Created OtelIdResolverTest.kt - Comprehensive tests for all ID resolution methods with fallback scenarios
• Created OtelPlatformProviderTest.kt - Tests for platform provider properties and factory function
• Created OneSignalCrashUploaderWrapperTest.kt - Tests for wrapper initialization and error handling
• Updated integration tests - OtelIntegrationTest, CrashReportUploadTest now use Context + SharedPreferences

OPTIONAL - Other

OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.

Testing

Unit testing

Lot of unit testing

Manual testing

Tested by manually crashing the app

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
  • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
  • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
• I have reviewed this PR myself, ensuring it meets each checklist item
  • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

---

This change is 

[github-actions]

📊 Diff Coverage Report

Diff Coverage Report

Threshold: 80%

Changed Files Coverage

• ⚠️ MainApplicationKT.kt: Not in coverage report (may not be compiled/tested)
• ⚠️ CoreModule.kt: Not in coverage report (may not be compiled/tested)
• ❌ IParamsBackendService.kt: 0/35 lines (0.0%)
  • ⚠️ Below threshold: 35 uncovered lines
• ❌ ParamsBackendService.kt: 0/95 lines (0.0%)
  • ⚠️ Below threshold: 95 uncovered lines
• ❌ ConfigModel.kt: 46/143 lines (32.2%)
  • ⚠️ Below threshold: 97 uncovered lines
• ❌ ConfigModelStore.kt: 0/2 lines (0.0%)
  • ⚠️ Below threshold: 2 uncovered lines
• ❌ ConfigModelStoreListener.kt: 0/67 lines (0.0%)
  • ⚠️ Below threshold: 67 uncovered lines
• ✅ HttpClient.kt: 131/151 lines (86.8%)
• ❌ Time.kt: 2/3 lines (66.7%)
  • ⚠️ Below threshold: 1 uncovered lines
• ❌ OneSignalCrashHandlerFactory.kt: 0/9 lines (0.0%)
  • ⚠️ Below threshold: 9 uncovered lines
• ❌ OneSignalCrashUploaderWrapper.kt: 0/11 lines (0.0%)
  • ⚠️ Below threshold: 11 uncovered lines
• ❌ OtelAnrDetector.kt: 0/99 lines (0.0%)
  • ⚠️ Below threshold: 99 uncovered lines
• ❌ Logging.kt: 52/102 lines (51.0%)
  • ⚠️ Below threshold: 50 uncovered lines
• ❌ AndroidOtelLogger.kt: 0/9 lines (0.0%)
  • ⚠️ Below threshold: 9 uncovered lines
• ❌ OtelIdResolver.kt: 0/95 lines (0.0%)
  • ⚠️ Below threshold: 95 uncovered lines
• ❌ OtelPlatformProvider.kt: 0/76 lines (0.0%)
  • ⚠️ Below threshold: 76 uncovered lines
• ❌ OneSignalCrashLogInit.kt: 0/52 lines (0.0%)
  • ⚠️ Below threshold: 52 uncovered lines
• ❌ OneSignalImp.kt: 60/262 lines (22.9%)
  • ⚠️ Below threshold: 202 uncovered lines
• ❌ IdentityModelStore.kt: 1/3 lines (33.3%)
  • ⚠️ Below threshold: 2 uncovered lines
• ❌ NotificationRestoreWorkManager.kt: 0/31 lines (0.0%)
  • ⚠️ Below threshold: 31 uncovered lines
• ❌ OneSignalOpenTelemetry.kt: 0/66 lines (0.0%)
  • ⚠️ Below threshold: 66 uncovered lines
• ❌ OtelFactory.kt: 0/23 lines (0.0%)
  • ⚠️ Below threshold: 23 uncovered lines
• ❌ OtelLoggingHelper.kt: 0/31 lines (0.0%)
  • ⚠️ Below threshold: 31 uncovered lines
• ❌ OtelFieldsPerEvent.kt: 0/13 lines (0.0%)
  • ⚠️ Below threshold: 13 uncovered lines
• ❌ OtelFieldsTopLevel.kt: 0/21 lines (0.0%)
  • ⚠️ Below threshold: 21 uncovered lines
• ❌ OtelConfigCrashFile.kt: 0/19 lines (0.0%)
  • ⚠️ Below threshold: 19 uncovered lines
• ❌ OtelConfigRemoteOneSignal.kt: 0/18 lines (0.0%)
  • ⚠️ Below threshold: 18 uncovered lines
• ❌ OtelConfigShared.kt: 0/18 lines (0.0%)
  • ⚠️ Below threshold: 18 uncovered lines
• ❌ OtelCrashHandler.kt: 0/42 lines (0.0%)
  • ⚠️ Below threshold: 42 uncovered lines
• ❌ OtelCrashReporter.kt: 0/33 lines (0.0%)
  • ⚠️ Below threshold: 33 uncovered lines
• ❌ OtelCrashUploader.kt: 0/29 lines (0.0%)
  • ⚠️ Below threshold: 29 uncovered lines

Overall Coverage

292/1558 lines covered (18.7%)

❌ Coverage Check Failed

Files below 80% threshold:

• IParamsBackendService.kt: 0.0% (35 uncovered lines)

• ParamsBackendService.kt: 0.0% (95 uncovered lines)

• ConfigModel.kt: 32.2% (97 uncovered lines)

• ConfigModelStore.kt: 0.0% (2 uncovered lines)

• ConfigModelStoreListener.kt: 0.0% (67 uncovered lines)

• Time.kt: 66.7% (1 uncovered lines)

• OneSignalCrashHandlerFactory.kt: 0.0% (9 uncovered lines)

• OneSignalCrashUploaderWrapper.kt: 0.0% (11 uncovered lines)

• OtelAnrDetector.kt: 0.0% (99 uncovered lines)

• Logging.kt: 51.0% (50 uncovered lines)

• AndroidOtelLogger.kt: 0.0% (9 uncovered lines)

• OtelIdResolver.kt: 0.0% (95 uncovered lines)

• OtelPlatformProvider.kt: 0.0% (76 uncovered lines)

• OneSignalCrashLogInit.kt: 0.0% (52 uncovered lines)

• OneSignalImp.kt: 22.9% (202 uncovered lines)

• IdentityModelStore.kt: 33.3% (2 uncovered lines)

• NotificationRestoreWorkManager.kt: 0.0% (31 uncovered lines)

• OneSignalOpenTelemetry.kt: 0.0% (66 uncovered lines)

• OtelFactory.kt: 0.0% (23 uncovered lines)

• OtelLoggingHelper.kt: 0.0% (31 uncovered lines)

• OtelFieldsPerEvent.kt: 0.0% (13 uncovered lines)

• OtelFieldsTopLevel.kt: 0.0% (21 uncovered lines)

• OtelConfigCrashFile.kt: 0.0% (19 uncovered lines)

• OtelConfigRemoteOneSignal.kt: 0.0% (18 uncovered lines)

• OtelConfigShared.kt: 0.0% (18 uncovered lines)

• OtelCrashHandler.kt: 0.0% (42 uncovered lines)

• OtelCrashReporter.kt: 0.0% (33 uncovered lines)

• OtelCrashUploader.kt: 0.0% (29 uncovered lines)

📥 View workflow run