-
Couldn't load subscription status.
- Fork 195
chore: remove unused packages #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3fd7643 to
f53325a
Compare
f53325a to
09e2931
Compare
| @@ -0,0 +1,68 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're switching to a different package manager, can you give details about this? Anything about bun or why you're making this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bun is pretty compatible drop in & a faster javascript runtime. Would also be faster for things like installing packages.
package.json
Outdated
| "license": "MIT", | ||
| "main": "dist/index.js", | ||
| "types": "dist/index.d.ts", | ||
| "files": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to include /src and build-extras-onesignal.gradle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill remove files for now.
Description
One Line Summary
Details
Motivation
Manual testing
ionic capacitor run androidandionic capacitor run iosAffected code checklist
Checklist
Overview
Testing
Final pass
This change is