Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Oct 21, 2025

Description

One Line Summary

  • clean up existing example packages

Details

  • remove useless cypress tests
  • add bun lock files and bun install for ci for fasting package installation

Motivation

  • want to clean up example packages
  • use bun lock instead of npm
  • update example packages

Manual testing

  • tested example app via ionic capacitor run android and ionic capacitor run ios

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george changed the title chore: update packages chore: clean up packages Oct 21, 2025
@@ -0,0 +1,68 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're switching to a different package manager, can you give details about this? Anything about bun or why you're making this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bun is pretty compatible drop in & a faster javascript runtime. Would also be faster for things like installing packages.

package.json Outdated
"license": "MIT",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to include /src and build-extras-onesignal.gradle?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill remove files for now.

@fadi-george fadi-george requested a review from nan-li October 22, 2025 23:01
@fadi-george fadi-george changed the title chore: clean up packages chore: remove unused packages Oct 23, 2025
@fadi-george fadi-george merged commit c80e523 into main Oct 24, 2025
4 checks passed
@fadi-george fadi-george deleted the fg/clean-up-packages branch October 24, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants