Skip to content

Blocked in Egypt #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kaabi opened this issue Jan 9, 2022 · 3 comments
Open

Blocked in Egypt #871

Kaabi opened this issue Jan 9, 2022 · 3 comments

Comments

@Kaabi
Copy link

Kaabi commented Jan 9, 2022 •
edited
Loading

Description:

as you may hear already Onesignal base domain is been blocked for 3 years or more now from many ISPs in Egypt, but any subdomains such as api.onesignal.com or app.onesignal.com are working fine.

but when I implemented your Web push notification SDK I see that most requests were made on api.onesignal.com but some requests are directed to the onesignal.com base domain which is a block.

image

Steps to Reproduce Issue:

  1. Open any web page that has your SDK from Egypt
  2. voila you will receive the error of connection error

Anything else:

this would be fixed if you completely changed all your SDK codes to be using https://api.onesignal.com/api/v1/sync/...... instead of https://onesignal.com/api/v1/sync/.............
Kaabi added a commit to Kaabi/OneSignal-Website-SDK that referenced this issue Jan 9, 2022
@Kaabi
Changing URL to api.onesignal.com
0f11380 
We have many issues with Onesignal based domain is being blocked in Egypt
you can check at iOS repo is been fixed may 2020 but in the Web SDK still some calls is called from the base onesignal URL

this will result to fix issue OneSignal#871
@rgomezp
Copy link
Contributor

rgomezp commented Feb 25, 2022

Duplicate of OneSignal/OneSignal-iOS-SDK#554

@rgomezp rgomezp marked this as a duplicate of OneSignal/OneSignal-iOS-SDK#554 Feb 25, 2022
@rgomezp rgomezp closed this as completed Feb 25, 2022
@mostafaamr137
Copy link

Hello @rgomezp this is not a duplicate because the web sdk here https://cdn.onesignal.com/sdks/OneSignalSDKWorker.js still using the base url https://onesignal.com/api/v1/ but it should be updated to https://api.onesignal.com/api/v1/sync/ can we get this resolved in the web too ?

@rgomezp rgomezp reopened this Nov 7, 2022
@mostafaamr137
Copy link

Hello @rgomezp please take in consideration that the getOneSignalResourceUrlPath function in OneSignalPageSDKES6.js file needs to be changed to https://assets.onesignal.com, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kaabi @rgomezp @mostafaamr137