Issue #112 introduce OpenEoBackendConfig usage

still need to be merged/unified with existing AggregatorConfig

related: Open-EO/openeo-python-driver#204

Author: soxofaan

conf/backend_config.py

@@ -0,0 +1,17 @@
+from openeo_driver.config import OpenEoBackendConfig
+from openeo_driver.server import build_backend_deploy_metadata
+
+import openeo_aggregator
+
+deploy_metadata = build_backend_deploy_metadata(
+    packages=["openeo", "openeo_driver", "openeo_aggregator"],
+)
+
+# TODO #112 Merge with `AggregatorConfig`
+config = OpenEoBackendConfig(
+    id="aggregator",
+    capabilities_title="openEO Platform",
+    capabilities_description="openEO Platform, provided through openEO Aggregator Driver",
+    capabilities_backend_version=openeo_aggregator.about.__version__,
+    capabilities_deploy_metadata=deploy_metadata,
+)

setup.py

@@ -28,7 +28,7 @@
         "requests",
         "attrs",
         "openeo>=0.17.0",
-        "openeo_driver>=0.53.1.dev",
+        "openeo_driver>=0.57.1.dev",
         "flask~=2.0",
         "gunicorn~=20.0",
         "python-json-logger>=2.0.0",

src/openeo_aggregator/app.py

@@ -7,20 +7,19 @@
 
 import flask
 import openeo_driver.views
-from openeo_driver.server import build_backend_deploy_metadata
+from openeo_driver.config.load import ConfigGetter
 from openeo_driver.util.logging import (
     LOGGING_CONTEXT_FLASK,
     get_logging_config,
     setup_logging,
 )
 from openeo_driver.utils import smart_bool
 
-import openeo_aggregator.about
 from openeo_aggregator.backend import (
     AggregatorBackendImplementation,
     MultiBackendConnection,
 )
-from openeo_aggregator.config import AggregatorConfig, get_config
+from openeo_aggregator.config import AggregatorConfig, get_config, get_config_dir
 
 _log = logging.getLogger(__name__)
 
@@ -51,6 +50,8 @@ def create_app(config: Any = None, auto_logging_setup: bool = True) -> flask.Fla
             context=LOGGING_CONTEXT_FLASK,
         ))
 
+    os.environ.setdefault(ConfigGetter.OPENEO_BACKEND_CONFIG, str(get_config_dir() / "backend_config.py"))
+
     config: AggregatorConfig = get_config(config)
     _log.info(f"Using config: {config}")
 
@@ -66,14 +67,9 @@ def create_app(config: Any = None, auto_logging_setup: bool = True) -> flask.Fla
         error_handling=config.flask_error_handling,
     )
 
-    deploy_metadata = build_backend_deploy_metadata(
-        packages=["openeo", "openeo_driver", "openeo_aggregator"],
-    )
     app.config.from_mapping(
-        OPENEO_TITLE="openEO Platform",
-        OPENEO_DESCRIPTION="openEO Platform, provided through openEO Aggregator Driver",
-        OPENEO_BACKEND_VERSION=openeo_aggregator.about.__version__,
-        OPENEO_BACKEND_DEPLOY_METADATA=deploy_metadata,
+        # Config hack to make backend_implementation available from pytest fixture
+        # TODO: is there another, less hackish way?
         OPENEO_BACKEND_IMPLEMENTATION=backend_implementation,
     )
 

src/openeo_aggregator/config.py

@@ -27,7 +27,7 @@ class ConfigException(ValueError):
     pass
 
 
-# TODO #112 subclass from OpenEoBackendConfig
+# TODO #112 subclass from OpenEoBackendConfig (attrs based instead of dictionary based)
 class AggregatorConfig(dict):
     """
     Simple dictionary based configuration for aggregator backend

tests/test_views.py

@@ -48,6 +48,12 @@ def test_capabilities(self, api100):
             "b2": {"url": "https://b2.test/v1"},
         }
 
+    def test_title_and_description(self, api100):
+        res = api100.get("/").assert_status_code(200)
+        capabilities = res.json
+        assert capabilities["title"] == "openEO Platform"
+        assert capabilities["description"] == "openEO Platform, provided through openEO Aggregator Driver"
+
     def test_capabilities_validation(self, api100):
         """https://github.com/Open-EO/openeo-aggregator/issues/42"""
         res = api100.get("/").assert_status_code(200)