Minor DoubleJobRegistry/JobRegistryInterface alignment tweaks

refs: #863, #1123

Author: soxofaan

openeogeotrellis/job_registry.py

@@ -650,7 +650,7 @@ def set_status(
         updated: Optional[str] = None,
         started: Optional[str] = None,
         finished: Optional[str] = None,
-    ) -> JobDict:
+    ) -> None:
         self._update(
             job_id=job_id,
             status=status,
@@ -660,7 +660,6 @@ def set_status(
             self._update(job_id=job_id, started=rfc3339.datetime(started))
         if finished:
             self._update(job_id=job_id, finished=rfc3339.datetime(finished))
-        return self.db[job_id]
 
     def set_dependencies(
         self, job_id: str, *, user_id: Optional[str] = None, dependencies: List[Dict[str, str]]
@@ -676,15 +675,16 @@ def set_dependency_status(self, job_id: str, *, user_id: Optional[str] = None, d
     def set_dependency_usage(self, job_id: str, *, user_id: Optional[str] = None, dependency_usage: Decimal) -> None:
         self._update(job_id, dependency_usage=str(dependency_usage))
 
-    def set_proxy_user(self, job_id: str, proxy_user: str) -> JobDict:
-        return self._update(job_id=job_id, proxy_user=proxy_user)
+    def set_proxy_user(self, job_id: str, proxy_user: str) -> None:
+        self._update(job_id=job_id, proxy_user=proxy_user)
 
     def set_application_id(self, job_id: str, application_id: str) -> JobDict:
         return self._update(job_id=job_id, application_id=application_id)
 
-    def set_results_metadata(self, job_id: str, costs: Optional[float], usage: dict,
-                             results_metadata: Dict[str, Any]) -> JobDict:
-        return self._update(job_id=job_id, costs=costs, usage=usage, results_metadata=results_metadata)
+    def set_results_metadata(
+        self, job_id: str, costs: Optional[float], usage: dict, results_metadata: Dict[str, Any]
+    ) -> None:
+        self._update(job_id=job_id, costs=costs, usage=usage, results_metadata=results_metadata)
 
     def list_user_jobs(
         self,
@@ -825,7 +825,7 @@ def create_job(
             raise DoubleJobRegistryException(f"None of ZK/EJR registered {job_id=}")
         return zk_job_info or ejr_job_info
 
-    def get_job(self, job_id: str, *, user_id: Optional[str] = None) -> dict:
+    def get_job(self, job_id: str, *, user_id: Optional[str] = None) -> JobDict:
         # TODO: eliminate get_job/get_job_metadata duplication?
         zk_job = ejr_job = None
         if self.zk_job_registry:
@@ -922,7 +922,7 @@ def set_dependency_usage(self, job_id: str, *, user_id: Optional[str] = None, de
                 job_id=job_id, user_id=user_id, dependency_usage=dependency_usage
             )
 
-    def set_proxy_user(self, job_id: str, user_id: str, proxy_user: str):
+    def set_proxy_user(self, job_id: str, user_id: str, proxy_user: str) -> None:
         # TODO: add dedicated method
         if self.zk_job_registry:
             self.zk_job_registry.patch(job_id=job_id, user_id=user_id, proxy_user=proxy_user)