Skip to content

fail silently when setting job to queued #1065 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fail silently when setting job to queued #1065 #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion openeogeotrellis/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,10 @@ def as_arg_element(dependency: dict) -> dict:

with self._double_job_registry as dbl_registry:
dbl_registry.set_application_id(job_id, user_id, application_id)
dbl_registry.set_status(job_id, user_id, JOB_STATUS.QUEUED)
try:
dbl_registry.set_status(job_id, user_id, JOB_STATUS.QUEUED)
except Exception:
log.warning("Failed to set job status to QUEUED. The job still started so we continue anyway.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for our own debugging purposes, including the exception message can be relevant here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also replace warning with info, the warning is not actionable from the user perspective

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make it more clear that this is just about updating the job status in the job registry, not about the actual job status


except _BatchJobError:
traceback.print_exc(file=sys.stderr)
Expand Down