Feature/s3 assets via s3 proxy #1157
Open
+611
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2025 16:06
If the geopyspark-driver has config set to be able to issue IDP tokens and the STS endpoint as well as a new config `s3_region_proxy_endpoints` which has the S3 proxy endpoint per region then it will generate presigned S3 urls for assets as long as it knows about the asset buckets via a workspace.
Since the new region config is used as feature flag it is better to have an explicit test case with other components configured but feature flag on default value (= feature disabled)
pvbouwel
force-pushed
the
feature/s3_assets_via_s3_proxy
branch
from
f4fa46a to
d0b1fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the geopyspark-driver has config set to be able to issue IDP tokens and the STS endpoint as well as a new config s3_region_proxy_endpoints which has the S3 proxy endpoint per region then it will generate presigned S3 urls for assets as long as it knows about the asset buckets via a workspace.
This builds on top of Open-EO/openeo-python-driver#387
The changes in conftest allows for easier overrides and thus as a workaround for Open-EO/openeo-python-driver#265
This replaces #1119