Skip to content

Commit e58e471

Browse files
restore logging after upgrade to Spark 3.5.x
* fix logging for some submodules #382 * Update logging in poms for more submodules #382 * DRY #382 * fixing logging restored additional jobs/stages #382 --------- Co-authored-by: Jan Van den bosch <jan.vandenbosch@hotmail.com>
1 parent 95aa2b1 commit e58e471

File tree

5 files changed

+13
-31
lines changed

5 files changed

+13
-31
lines changed

geotrellis-sentinelhub/pom.xml

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -41,30 +41,6 @@
4141
</exclusion>
4242
</exclusions>
4343
</dependency>
44-
<dependency>
45-
<groupId>org.apache.hadoop</groupId>
46-
<artifactId>hadoop-mapreduce-client-core</artifactId>
47-
<version>${hadoop.version}</version>
48-
<scope>provided</scope>
49-
<exclusions>
50-
<exclusion>
51-
<groupId>org.slf4j</groupId>
52-
<artifactId>slf4j-log4j12</artifactId>
53-
</exclusion>
54-
</exclusions>
55-
</dependency>
56-
<dependency>
57-
<groupId>org.apache.hadoop</groupId>
58-
<artifactId>hadoop-common</artifactId>
59-
<version>${hadoop.version}</version>
60-
<scope>provided</scope>
61-
<exclusions>
62-
<exclusion>
63-
<groupId>org.slf4j</groupId>
64-
<artifactId>slf4j-log4j12</artifactId>
65-
</exclusion>
66-
</exclusions>
67-
</dependency>
6844
<dependency>
6945
<groupId>software.amazon.awssdk</groupId>
7046
<artifactId>s3</artifactId>
@@ -120,9 +96,9 @@
12096
<scope>test</scope>
12197
</dependency>
12298
<dependency>
123-
<groupId>com.sksamuel.elastic4s</groupId>
99+
<groupId>nl.gn0s1s</groupId>
124100
<artifactId>elastic4s-client-esjava_${scala.binary.version}</artifactId>
125-
<version>7.8.1</version>
101+
<version>7.17.25</version>
126102
<exclusions>
127103
<exclusion>
128104
<groupId>com.fasterxml.jackson.core</groupId>

openeo-geotrellis/src/main/scala/org/openeo/geotrellis/layers/FileLayerProvider.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,7 @@ object FileLayerProvider {
434434
val filtered = prepareMask(theMask, metadata, partitioner)
435435

436436
if (logger.isDebugEnabled) {
437+
// the number of jobs/stages effectively depends on whether logging is correctly configured
437438
logger.debug(s"SpacetimeMask mask reduces the input to: ${filtered.countApproxDistinct()} keys.")
438439
}
439440

openeo-geotrellis/src/test/scala/org/openeo/geotrellis/layers/Sentinel2FileLayerProviderTest.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -598,9 +598,9 @@ class Sentinel2FileLayerProviderTest extends RasterMatchers {
598598
val referenceTile = GeoTiffRasterSource(ref).read().get
599599
val actualTile = GeoTiffRasterSource(actual).read().get
600600
assertRastersEqual(referenceTile, actualTile, 160.0)
601-
//because debugging is enabled, it actually runs more jobs and stages then done in production
602-
assertEquals(4,listener.getJobsCompleted)
603-
assertEquals(17, listener.getStagesCompleted)
601+
//because debug logging is enabled during tests, it actually runs more jobs and stages than done in production
602+
assertEquals(5, listener.getJobsCompleted)
603+
assertEquals(18, listener.getStagesCompleted)
604604

605605
}
606606

openeo-logging/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,12 @@
4141
<dependency>
4242
<groupId>org.slf4j</groupId>
4343
<artifactId>slf4j-api</artifactId>
44-
<version>2.0.6</version>
4544
<scope>test</scope>
4645
</dependency>
4746
<dependency>
4847
<groupId>org.apache.logging.log4j</groupId>
4948
<artifactId>log4j-slf4j-impl</artifactId>
50-
<version>2.19.0</version>
49+
<version>2.20.0</version>
5150
<scope>test</scope>
5251
</dependency>
5352
<dependency>

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@
4141
<artifactId>scala-library</artifactId>
4242
<version>${scala.version}</version>
4343
</dependency>
44+
<dependency>
45+
<groupId>org.slf4j</groupId>
46+
<artifactId>slf4j-api</artifactId>
47+
<version>2.0.7</version>
48+
<scope>provided</scope>
49+
</dependency>
4450
</dependencies>
4551
</dependencyManagement>
4652

0 commit comments

Comments
 (0)