Prevent changing objects in outer scope passed into a method.

m-mohr · m-mohr · commit 99ed275f0f4d · 2019-02-01T16:34:23.000+01:00
diff --git a/openeo.js b/openeo.js
@@ -219,7 +219,7 @@ class Connection {
 	}
 
 	createJob(processGraph, outputFormat = null, outputParameters = {}, title = null, description = null, plan = null, budget = null, additional = {}) {
-		var jobObject = Object.assign(additional, {
+		var jobObject = Object.assign({}, additional, {
 			title: title,
 			description: description,
 			process_graph: processGraph,
@@ -553,7 +553,7 @@ class Subscriptions {
 			parameters = {};
 		}
 
-		var payloadParameters = Object.assign(parameters, { topic: topic });
+		var payloadParameters = Object.assign({}, parameters, { topic: topic });
 
 		this._sendMessage(action, {
 			topics: [payloadParameters]

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ class Connection {`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`createJob(processGraph, outputFormat = null, outputParameters = {}, title = null, description = null, plan = null, budget = null, additional = {}) {`
`222`		`- var jobObject = Object.assign(additional, {`
	`222`	`+ var jobObject = Object.assign({}, additional, {`
`223`	`223`	`title: title,`
`224`	`224`	`description: description,`
`225`	`225`	`process_graph: processGraph,`
`@@ -553,7 +553,7 @@ class Subscriptions {`
`553`	`553`	`parameters = {};`
`554`	`554`	`}`
`555`	`555`
`556`		`- var payloadParameters = Object.assign(parameters, { topic: topic });`
	`556`	`+ var payloadParameters = Object.assign({}, parameters, { topic: topic });`
`557`	`557`
`558`	`558`	`this._sendMessage(action, {`
`559`	`559`	`topics: [payloadParameters]`