Improve federation support #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If coming from a spec-compliant backend, `this.data.federation` is an object, so the function used to always return the empty array. The code now transforms the object into an array, and also adds the former object keys to each item as an `id` property.
Thanks automatic tests
m-mohr
reviewed
Apr 9, 2025
m-mohr
approved these changes
Apr 10, 2025
This was
linked to
issues
Apr 10, 2025
|
@m-mohr Please check the additional commits I just added and then I think we could put a new version number and merge this? Or should we wait in case more changes become necessary while working on more stuff in the depending repos? |
m-mohr
reviewed
Apr 11, 2025
m-mohr
reviewed
Apr 11, 2025
m-mohr
reviewed
Apr 11, 2025
|
I think we can merge this after resolving the comments, but should continue working on the other cases, e.g. jobs, services before we release. |
m-mohr
reviewed
Apr 11, 2025
|
Okay, implemented your last recent comment. I didn't address the "couldn't find backendId" case in the JSDoc for lack of a good description plus not finding it too relevant anyway; if you happen to come up with a good text let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
idfields to the objects in the array returned bylistFederationinCapabilities, so that the backend details can be linked to what's infederation:backendsandfederation:missing, which are just lists of IDs.Also, it fixes that
listFederationused to always return the empty array, as it expectedfederationto be an array, while it's actually always an object.