Issue #737 assume presence of spatial dimensions in load_stac result

This is not perfect, but at least a quick fix for common use cases

Author: soxofaan

openeo/metadata.py

@@ -655,9 +655,16 @@ def is_band_asset(asset: pystac.Asset) -> bool:
     else:
         raise ValueError(stac_object)
 
+    # At least assume there are spatial dimensions
+    # TODO: are there conditions in which we even should not assume the presence of spatial dimensions?
+    dimensions = [
+        SpatialDimension(name="x", extent=[None, None]),
+        SpatialDimension(name="y", extent=[None, None]),
+    ]
+
     # TODO: conditionally include band dimension when there was actual indication of band metadata?
     band_dimension = BandDimension(name="bands", bands=bands)
-    dimensions = [band_dimension]
+    dimensions.append(band_dimension)
 
     # TODO: is it possible to derive the actual name of temporal dimension that the backend will use?
     temporal_dimension = _StacMetadataParser().get_temporal_dimension(stac_object)

tests/rest/datacube/test_datacube.py

@@ -6,6 +6,7 @@
 """
 
 import contextlib
+import json
 import pathlib
 import re
 from datetime import date, datetime
@@ -25,6 +26,7 @@
 from openeo.rest._testing import build_capabilities
 from openeo.rest.connection import Connection
 from openeo.rest.datacube import DataCube
+from openeo.testing.stac import StacDummyBuilder
 from openeo.util import dict_no_none
 
 from .. import get_download_graph
@@ -312,6 +314,41 @@ def test_load_stac_spatial_extent_parameter(self, dummy_backend):
             "spatial_extent": {"from_parameter": "zpatial_extent"},
         }
 
+    @pytest.mark.parametrize(
+        "stac_metadata",
+        [
+            StacDummyBuilder.item(),
+            StacDummyBuilder.collection(),
+            StacDummyBuilder.catalog(),
+        ],
+    )
+    def test_load_stac_resample_spatial(self, dummy_backend, tmp_path, stac_metadata):
+        """https://github.com/Open-EO/openeo-python-client/issues/737"""
+        stac_path = tmp_path / "stac.json"
+        # TODO #738 real request mocking of STAC resources compatible with pystac?
+        stac_path.write_text(json.dumps(stac_metadata))
+        cube = dummy_backend.connection.load_stac(str(stac_path))
+        cube = cube.resample_spatial(resolution=10, projection=4326)
+        cube.execute()
+        assert dummy_backend.get_sync_pg() == {
+            "loadstac1": {
+                "process_id": "load_stac",
+                "arguments": {"url": dirty_equals.IsStr(regex=".*/stac.json")},
+            },
+            "resamplespatial1": {
+                "process_id": "resample_spatial",
+                "arguments": {
+                    "data": {"from_node": "loadstac1"},
+                    "projection": 4326,
+                    "resolution": 10,
+                    "method": "near",
+                    "align": "upper-left",
+                },
+                "result": True,
+            },
+        }
+
+
 def test_filter_temporal_basic_positional_args(s2cube):
     im = s2cube.filter_temporal("2016-01-01", "2016-03-10")
     graph = _get_leaf_node(im)