Skip to content

Commit bd9c9d4

Browse files
committed
Skip test for #714 on py3.8 due to lack of geopandas support
Workaround for #714 requires at least geopandas 0.14 but that version is not available on Python 3.8 (#717)
1 parent 0d295dc commit bd9c9d4

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

setup.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@
2525
"urllib3<2.3.0", # httpretty doesn't work properly with urllib3>=2.3.0. See #700 and https://github.com/gabrielfalcao/HTTPretty/issues/484
2626
"netCDF4>=1.7.0",
2727
"matplotlib", # TODO: eliminate matplotlib as test dependency
28-
"geopandas>0.13.2",
28+
# TODO #717 Simplify geopandas constraints when Python 3.8 support is dropped
29+
"geopandas>=0.14; python_version>='3.9'",
30+
"geopandas", # Best-effort geopandas dependency for Python 3.8
2931
"flake8>=5.0.0",
3032
"time_machine",
3133
"pyproj>=3.2.0", # Pyproj is an optional, best-effort runtime dependency

tests/extra/job_management/test_job_management.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import copy
2+
import datetime
23
import json
34
import logging
45
import re
@@ -7,7 +8,6 @@
78
from time import sleep
89
from typing import Callable, Union
910
from unittest import mock
10-
import datetime
1111

1212
import dirty_equals
1313
import geopandas
@@ -40,6 +40,7 @@
4040
)
4141
from openeo.rest._testing import OPENEO_BACKEND, DummyBackend, build_capabilities
4242
from openeo.util import rfc3339
43+
from openeo.utils.version import ComparableVersion
4344

4445

4546
@pytest.fixture
@@ -977,6 +978,10 @@ def test_initialize_from_df_on_exists_skip(self, tmp_path):
977978
)
978979
assert set(db.read()["some_number"]) == {1, 2, 3}
979980

981+
@pytest.mark.skipif(
982+
ComparableVersion(geopandas.__version__) < "0.14",
983+
reason="This issue has no workaround with geopandas < 0.14 (highest available version on Python 3.8 is 0.13.2)",
984+
)
980985
def test_read_with_crs_column(self, tmp_path):
981986
"""
982987
Having a column named "crs" can cause obscure error messages when creating a GeoPandas dataframe

0 commit comments

Comments
 (0)