testing.results.assert_job_results_allclose: add guardrails against passing single file

instead of folder

Author: soxofaan

openeo/testing/results.py

@@ -396,10 +396,10 @@ def _as_job_results_download(
         _log.info(f"Downloading results from job {job_results.get_job_id()} to {download_dir}")
         job_results.download_files(target=download_dir)
         job_results = download_dir
-    if isinstance(job_results, (str, Path)):
-        return Path(job_results)
+    if isinstance(job_results, (str, Path)) and (job_results := Path(job_results)).is_dir():
+        return job_results
     else:
-        raise ValueError(f"Unsupported type: {type(job_results)}")
+        raise ValueError(f"Expected a directory with job result assets, but got {job_results!r}")
 
 
 def _compare_job_results(
@@ -425,6 +425,8 @@ def _compare_job_results(
 
     actual_filenames = set(p.name for p in actual_dir.glob("*") if p.is_file())
     expected_filenames = set(p.name for p in expected_dir.glob("*") if p.is_file())
+    if len(actual_filenames) == 0 or len(expected_filenames) == 0:
+        _log.warning(f"Empty actual/expected listing: {actual_filenames=} {expected_filenames=}")
     if actual_filenames != expected_filenames:
         all_issues.append(f"File set mismatch: {actual_filenames} != {expected_filenames}")
 

tests/testing/test_results.py

@@ -619,3 +619,11 @@ def test_assert_job_results_allclose_derived_from_mismatch(self, tmp_path, actua
             message="Differing 'derived_from' links.*1 common, 1 only in actual, 2 only in expected.*only in actual.*bla_666.*only in expected.*bla_3"
         ):
             assert_job_results_allclose(actual=actual_dir, expected=expected_dir, tmp_path=tmp_path)
+
+    def test_allclose_must_be_folder(self, tmp_path, actual_dir, expected_dir):
+        expected = expected_dir / "readme.md"
+        expected.write_text("Hello world")
+        actual = actual_dir / "readme.md"
+        actual.write_text("Wello Horld")
+        with pytest.raises(ValueError, match="Expected a directory"):
+            assert_job_results_allclose(actual=actual, expected=expected, tmp_path=tmp_path)