Skip to content

Add sen2like process #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ValentinaHutter opened this issue Jul 5, 2023 · 5 comments
Open

Add sen2like process #446

ValentinaHutter opened this issue Jul 5, 2023 · 5 comments

Comments

@ValentinaHutter
Copy link

I wanted to ask, if it would be possible to add a .sen2like() to the openeo-python-client? The process would be used directly on a SENTINEL2_L1C datacube using data.sen2like(spatial_extent = ?bounding-box:object , temporal_extent = ?temporal-interval:array<string|null>, target_product = ?string, target_resolution = ?number, options = ?object) So, all of the parameters are optional.

The process definition can also be found under: https://github.com/eodcgmbh/openeo-processes/blob/master/sen2like.json

Thanks in advance!

@soxofaan
Copy link
Member

soxofaan commented Jul 7, 2023

It's an experimental, back-end specific process, bit shouldn't be too hard too add.

note that it is already possible to add this sen2like to your process graph without a dedicated DataCube method, using the generic way as explained in https://open-eo.github.io/openeo-python-client/processes.html#passing-data-cube-arguments, e.g.:

cube = cube.process(
    "sen2like", 
    data=cube,
    spatial_extent=...,
    temporal_extent=...,
    target_product=..., 
    target_resolution=....,
    options=...
)

@soxofaan
Copy link
Member

soxofaan commented Jul 12, 2023

just to set expectations right: it's unlikely we'll be able to address this issue soon as we're handling some higher prio issues with reduced work force (due to holidays), and there is already a generic workaround available

(PRs are welcome of course 😄 )

@jdries
Copy link
Collaborator

jdries commented Jul 17, 2023

@ValentinaHutter does the generic way work for you? @vito we also have some custom processes, but never add them to the python client as a dedicated method because they are not official ones.

@soxofaan
Copy link
Member

side-note: we also have this feature idea of dynamically supporting processes: #40

@LukeWeidenwalker
Copy link

@ValentinaHutter is currently on holiday, so jumping in here!

Thanks for your comments both!

This was requested by @patrick-griffiths in our last chat as an improvement to user-friendliness of the sen2like processor - @patrick-griffiths could you please comment on whether this is still desirable in light of these comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants