Skip to content

Job manager: Move jobdatabase classes out of __init__ #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VictorVerhaert opened this issue Feb 26, 2025 · 1 comment
Open

Job manager: Move jobdatabase classes out of __init__ #741

VictorVerhaert opened this issue Feb 26, 2025 · 1 comment

Comments

@VictorVerhaert
Copy link
Contributor

the init file currently contains a lot of logic making it hard for new users to figure out how it works.

One way of cleaning this file is moving job database logic to a separate file `job_database.py' (and including the stac api one)

In order to prevent existing links from breaking we can import the databases and add them to the all variable as described here:
https://docs.astral.sh/ruff/rules/unused-import/
(I realize we don't use ruff as a linting tool but still believe we should add it to all)

@soxofaan
Copy link
Member

fully agree to move all implementation out of job_management/__init__.py into submodules

However, there are a couple of ongoing job manager PRs, so we have to be careful when to start and merge the move to avoid branch conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants