First version of tile based job splitter #756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdries
reviewed
Apr 2, 2025
jdries
reviewed
Apr 2, 2025
jdries
requested changes
Apr 2, 2025
soxofaan
reviewed
Apr 8, 2025
soxofaan
added a commit
that referenced
this pull request
Apr 29, 2025
soxofaan
added a commit
that referenced
this pull request
Apr 29, 2025
|
as discussed offline: I made job_splitting a private submodule, moved a couple of review notes as TODO comments in the code, (rebased) and merged in ee18290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first version of a
split_areafunction based on aSizeBasedTileGridclass.dictandshapely.geometry.Polygonobjectscloses #745
@soxofaan, @jdries, besides the general review, I could use your help to advice on how to expose this to users and leave flexibility of adding more
TileGridInterfaceclasses in the future.