Skip to content

DataCube.apply_dimension should not have a default dimension #774

Open
@soxofaan

Description

@soxofaan

this default "t" for dimension arg in applu_dimension is overly opinionated (and apparently causing confusion about how the process handles dimensions):

def apply_dimension(
self,
code: Optional[str] = None,
runtime=None,
# TODO: drop None default of process (when `code` and `runtime` args can be dropped)
process: Union[str, typing.Callable, UDF, PGNode] = None,
version: Optional[str] = None,
# TODO: dimension has no default (per spec)?
dimension: str = "t",

DataCube.apply_dimension should align better with the official spec (required arg with no default)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions