-
Notifications
You must be signed in to change notification settings - Fork 44
747 robustranged download support #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial notes
This reverts commit bc54f00.
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
@soxofaan ok to merge? Broken downloads is a big issue for many users, and this might really help quite a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is still a regression here:
non ranged downloads will be done as a whole in memory instead of being chunked
@dsamaey indeed, for the 'download all at once' code path, we can just make sure to use what was already there, and then this should be fine:
Can you merge that in? |
Manually tested with https://openeo.dataspace.copernicus.eu/openeo/1.2/jobs/j-2504020555234b3287f2fe696bea5ded/results/assets/MzJjYzdkZGItZjdlMS00YjFjLTk3OTYtZjlmZTM5Y2I4ZmVi/efc6009b1fdb1d283b91e65538400aac/feature-datacubes_v1_feature-cube_year2024_E412N322.tif?expires=1744207076
Chunks are directly written to the file since all chunks are downloaded (and retried) sequentially.