Add message to assert, and add it to the ProcessGraphInvalidException #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Jun 10, 2024
openeo_driver/errors.py
Outdated
| @@ -371,6 +371,12 @@ class ProcessGraphInvalidException(OpenEOApiException): | |||
| _description = "The process doesn't contain a valid process graph, which means it doesn't comply to the general structure / schema." | |||
| _tags = ['Batch Jobs', 'Data Processing', 'Secondary Services', 'User-Defined Processes'] | |||
|
|
|||
| def __init__(self, message: str = ""): | |||
There was a problem hiding this comment.
I would not add methods here, the exception classes here are compiled/autogenerated from JSON from openeo-api:
Note that the OpenEOApiException base class already has an __init__ that should be enough to do this.
And also note that by overriding __init__ you'll probably break current usage of that
There was a problem hiding this comment.
The 'Invalid process graph specified.' message is gone then. Ok?
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
|
Actually, this is a bit related to a ticket assigned to me (which will involve changing this whole function), so maybe I should take over here (related to Open-EO/openeo-api#515) |
soxofaan
added a commit
that referenced
this pull request
Jun 10, 2024
Based on PR #290, related to Open-EO/openeo-api#515
|
overruled by 4215641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.