-
Notifications
You must be signed in to change notification settings - Fork 1
Improve federation support #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I returned `true` too eagerly :D When it's not a federation context, of course supportedBy is undefined, so affectedByMissing became true. The Notice didn't render anyway because of further checks in the component itself, but it was added to the DOM and that should be avoided too.
Thanks. Just a couple of clean-ups, othewise LGTM. |
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Screenshots can be seen in the corresponding Web Editor PR: Open-EO/openeo-web-editor#353 (comment) |
With regards to the Federation and Missing notice:
|
I'd keep it -- yes it will always be "offline", but I don't see it primarily as a way to convey changing information, but more as a general design element which warns the user. I bet this catches more attention than the "Incomplete" heading of the box. Regarding the texts, I changed them the way you wanted, but remain unconvinced that we have reached the best possible solution for communicating federation information. |
Actually, I just realized that there are edge cases where it can be online, too. Having that said, the solution is good enough for now with potential improvements to be made in the future. For now we need to go forward with other tasks. Thanks. |
Several improvements for rendering Federation(Missing)Notices