Skip to content

Improve federation support #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025
Merged

Improve federation support #102

merged 8 commits into from
Apr 15, 2025

Conversation

christophfriedrich
Copy link
Collaborator

Several improvements for rendering Federation(Missing)Notices

I returned `true` too eagerly :D When it's not a federation context, of course supportedBy is undefined, so affectedByMissing became true. The Notice didn't render anyway because of further checks in the component itself, but it was added to the DOM and that should be avoided too.
@m-mohr
Copy link
Member

m-mohr commented Apr 9, 2025

Thanks. Just a couple of clean-ups, othewise LGTM.
Could you share a screenshot of how it looks now, please?

Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@christophfriedrich
Copy link
Collaborator Author

christophfriedrich commented Apr 10, 2025

Screenshots can be seen in the corresponding Web Editor PR: Open-EO/openeo-web-editor#353 (comment)

@m-mohr
Copy link
Member

m-mohr commented Apr 10, 2025

With regards to the Federation and Missing notice:

  • The online/offline notice in the federation missing notice is not really needed, als it will always be offline. I'd remove it from there.
  • We should probably shorten the text slightly for the Federation missing notice: The following data is incomplete as the following services in the federation are currently not available: ... - makes it also a little less wasteful with regards to space in the Web Editor and solves FederationMissingNotice in Collection component not fitting and redundant #100.

@christophfriedrich
Copy link
Collaborator Author

The online/offline notice in the federation missing notice is not really needed, als it will always be offline. I'd remove it from there.

I'd keep it -- yes it will always be "offline", but I don't see it primarily as a way to convey changing information, but more as a general design element which warns the user. I bet this catches more attention than the "Incomplete" heading of the box.


Regarding the texts, I changed them the way you wanted, but remain unconvinced that we have reached the best possible solution for communicating federation information.

@m-mohr
Copy link
Member

m-mohr commented Apr 15, 2025

Actually, I just realized that there are edge cases where it can be online, too.
The backend status can be online, but the cache for processes in the aggregator can still be outdated and miss a specific backend that was previously offline. It also could work the other way around where a backend is offline, but the cache still holds the information for the processes...

Having that said, the solution is good enough for now with potential improvements to be made in the future. For now we need to go forward with other tasks. Thanks.

@m-mohr m-mohr merged commit 6f2c89a into master Apr 15, 2025
@m-mohr m-mohr deleted the improve-federation-support branch April 15, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants