Skip to content

Fix showing logic for notices, add compact style #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

christophfriedrich
Copy link
Collaborator

No description provided.

@christophfriedrich christophfriedrich linked an issue Apr 23, 2025 that may be closed by this pull request
4 tasks
@christophfriedrich
Copy link
Collaborator Author

Possibly convert to draft, I still want to add an example for the compact style but need the fixes from master for that

Comment on lines +19 to +22
<section class="description" v-if="stac.description || stac.deprecated || supportedBy || affectedByMissing">
<h3>Description</h3>

<Description :description="stac.description"></Description>
<Description v-if="stac.description" :description="stac.description"></Description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Description header is shown even if no description is shown, may also apply to other components.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct, for all the changed components. In my stump this happens e.g. for the service types in the ServerInfo modal. Looks like this:

image

I didn't find that overly inappropriate, so I left it as it is.

But would you prefer to show the heading only if there really is a description? Could easily be achieved with a v-if="stac.description" on the <h3>.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can skip the description header in those cases. The proposed solution sounds reasonable.

Copy link
Collaborator Author

@christophfriedrich christophfriedrich Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about processes? Apart from the notices they always have a signature. This is what it would look like:

image

vs.

image

for reference with actual description:

image

In general: Would it be more consistent to always have the notices outside of the Description heading?

Copy link
Member

@m-mohr m-mohr Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on the edge, both options seem fine for me. Implement your preferred way ;-)

@m-mohr m-mohr force-pushed the improve-federation-support-continued branch from 1a651aa to 616ea05 Compare April 23, 2025 13:55
@m-mohr
Copy link
Member

m-mohr commented Apr 23, 2025

Generally looks good, thanks. I rebased the PR to include the main changes and left one comment with regards to the Description heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for the Federation Extension
2 participants