-
Notifications
You must be signed in to change notification settings - Fork 18
Implement support for the Federation Extension #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Add a warning icon with the FA icon ( For jobs, services, files, UDPs a button with icon should work, for collections, processes, file formats it might just be a clickable icon without button style as it might look more pleasing. The JS client v2.7.0 supports the functionality to retrieve the properties since some months, see also Open-EO/openeo-js-client@fd78bb8 and Open-EO/openeo-js-client@2a14de7 The list of missing backends with a short explanation could be shown in a modal, toast or tooltip. High prio tasks should be implemented first. |
This can already be used with the version of the js-client on the `federation-as-object` branch there.
And one more in the DiscoveryToolbar
Regarding the issue that we don't really like a tooltip on a button, but a modal would also be overkill: How would you like a "compact" version of the FederationMissingNotice for the panels? Which styling is desired could be set via a boolean Consumes one line of space (two if the availability situation is really bad or the screen particularly small), but would be consistent with the rest and IMO fairly pleasing visually. |
I like that. I'd also expect that usually it's only a single backend, so the text should usually be a bit shorter. |
Nice, then I'll finish implementing that. For now I made it as a separate component in the templates of the panels (requiring to wrap everything in a new <template>
<div id="JobPanel">
<FederationMissingNotice ... />
<DataTable ... >
<template slot="toolbar">
...
</template>
...
</DataTable>
</div>
</template> Or would you prefer adding a new slot to DataTable? Would then look like this: <template>
<DataTable ... >
<template slot="notice">
<FederationMissingNotice ... />
</template>
<template slot="toolbar">
...
</template>
...
</DataTable>
</template> The latter would give the option to switch the places of toolbar and notice, but I prefer the current layout anyway (tools to manipulate the table are directly above it, not split from it by an annoying notice). Semantically I think one could find arguments for either version. |
I think I'd go with the first option, that seems a little more clean. |
See Open-EO/openeo-api#419 and https://github.com/Open-EO/openeo-api/blob/draft/extensions/federation/README.md
An intiial implementation: https://github.com/openEOPlatform/architecture-docs/issues/179#issuecomment-1007453499
In the EOEPCA+ project, we made an evaluation of the federation-related functionality available through the openEO Web Editor.
The following issues have been identified:
federation:missing
can't be accessed through the corresponding functions for the following endpoints:GET /collections
(high prio)GET /processes
(high)GET /file_formats
(high)GET /process_graphs
(high)GET /files
(high)GET /jobs
(high)GET /jobs/:id/logs
(low, missing upstream in Vue Components)GET /services
(high)GET /services/:id/logs
(low, missing upstream in Vue Components)federation:backends
can't be accessed through the corresponding functions for the following endpoints:POST /validation
(medium)GET /udf_runtimes
per version (low, missing upstream in Vue Components)GET /services/{id}
(low, missing upstream in Vue Components)Related issue for the upstream issues in Vue Components: Open-EO/openeo-vue-components#97
The text was updated successfully, but these errors were encountered: