-
Notifications
You must be signed in to change notification settings - Fork 18
Improve federation support #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This can already be used with the version of the js-client on the `federation-as-object` branch there.
Thanks. Setting to draft until we have a new version number for the JS client so that we can also update the dependency in the package.json. The same request as in the Vue components: A screenshot would be nice ;-) |
see https://github.com/Open-EO/openeo-web-editor/pull/353/files/5809f11e5917b3d8d465003cf6a25247866c05f1#r2036257667 Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
Good point that the dependency needs to be released and filled in before it makes sense to merge this. Screenshot of In I didn't implement the Screenshot of Currently still accompanied by That is redundant, which I addressed in Open-EO/openeo-vue-components#100, but I was kinda waiting for your feedback on Open-EO/openeo-vue-components#101 before changing it. |
Thanks. We can keep it as is for now, the I've added more details to the issues and the PRs in vue-components. |
And one more in the DiscoveryToolbar
...Utils.mapState(namespace, ['missing']), | ||
...Utils.mapState(namespace, {data: namespace}), | ||
...Utils.mapState(namespace, ['pages', 'hasMore']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Utils.mapState(namespace, ['missing']), | |
...Utils.mapState(namespace, {data: namespace}), | |
...Utils.mapState(namespace, ['pages', 'hasMore']), | |
...Utils.mapState(namespace, {data: namespace}), | |
...Utils.mapState(namespace, ['missing', 'pages', 'hasMore']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda liked keeping all federation stuff together (line 28 and 29) and separating it from the rest (first two lines federation, then the rest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep it as concise as possible to avoid potential confusion, I also had to look for a second to realize it's the same namespace. We also kept it together in all other instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, sounds reasonable too
@@ -112,6 +112,7 @@ export default ({namespace, listFn, paginateFn, createFn, updateFn, deleteFn, re | |||
for (let d of data) { | |||
state[namespace].push(d); | |||
} | |||
state.missing = data['federation:missing']; // yes, accessing a property on an array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing is not initiated in the getDefaultState method above, I could imagine that this could become an issue and lead to the reactivity issues you faced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!! I added it to getDefaultState and the weird behaviour indeed went away. Let's see if this fix is more permanent now 😆
While taking the screenshots I realised that sometimes the FederationMissingNotice is displayed in the I was able to reproduce: It is orange as long as no FederationNotice has been added to the DOM, then it changes to gold. Probably need to adapt CSS specificity in FederationMissingNotice to overwrite more permanently, or not use the same class names for the two components in the first place. Could also make the style scoped? |
Make federation info actually available to the utilised vue-components
Collection
,Collections
,Processes
,FileFormats
.