Skip to content

Commit 73d40df

Browse files
Cleanup ToChannel extensions to reuse functional handling.
1 parent c4518f3 commit 73d40df

File tree

9 files changed

+1151
-1484
lines changed

9 files changed

+1151
-1484
lines changed

.editorconfig

+7-1
Original file line numberDiff line numberDiff line change
@@ -173,4 +173,10 @@ dotnet_naming_style.pascal_case.capitalization = pascal_case
173173
[*.cs]
174174

175175
# CA1510: Use ArgumentNullException throw helper
176-
dotnet_diagnostic.CA1510.severity = silent
176+
dotnet_diagnostic.CA1510.severity = silent
177+
178+
# IDE0130: Namespace does not match folder structure
179+
dotnet_diagnostic.IDE0130.severity = silent
180+
181+
# IDE0305: Simplify collection initialization
182+
dotnet_diagnostic.IDE0305.severity = silent

Source/Channel/AsChannel.cs

-656
This file was deleted.

Source/Channel/ToChannel.Target.cs

+832
Large diffs are not rendered by default.

Source/Channel/ToChannel.cs

+307-810
Large diffs are not rendered by default.

Source/Core/Extensions/DataReader.cs

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-

2-
using System.Runtime.CompilerServices;
3-
4-
namespace Open.Database.Extensions;
1+
namespace Open.Database.Extensions;
52

63
/// <summary>
74
/// Extension methods for Data Readers.
85
/// </summary>
6+
#pragma warning disable IDE0079 // Remove unnecessary suppression
97
[SuppressMessage("Design", "CA1068:CancellationToken parameters must come last", Justification = "Overload provided for convienience.")]
108
[SuppressMessage("Reliability", "CA2016:Forward the 'CancellationToken' parameter to methods that take one", Justification = "Intentional to prevent cancellation exception.")]
9+
#pragma warning restore IDE0079 // Remove unnecessary suppression
1110
public static class DataReaderExtensions
1211
{
1312
/// <summary>
@@ -454,7 +453,6 @@ static async IAsyncEnumerable<object[]> AsAsyncEnumerableInternalCore(DbDataRead
454453
}
455454
}
456455

457-
[System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2016:Forward the 'CancellationToken' parameter to methods that take one", Justification = "Intentional for this method to prevent cancellation exception.")]
458456
static IAsyncEnumerable<object[]> AsAsyncEnumerableInternal(
459457
this DbDataReader reader,
460458
IEnumerable<int> ordinals,

Source/Core/Extensions/IExecuteReader.cs

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Open.Database.Extensions.Core;
2-
3-
namespace Open.Database.Extensions;
1+
namespace Open.Database.Extensions;
42

53
/// <summary>
64
/// Core non-DB-specific extensions for retrieving data from a command using best practices.

Source/Core/Extensions/_.cs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Linq.Expressions;
2-
using System.Reflection;
32

43
namespace Open.Database.Extensions;
54

Source/MSSqlClient/.editorconfig

-4
This file was deleted.

Source/SqlClient/.editorconfig

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
[*.cs]
22

33
# CS0618: Type or member is obsolete
4-
dotnet_diagnostic.CS0618.severity = silent
5-
6-
# IDE0130: Namespace does not match folder structure
7-
dotnet_diagnostic.IDE0130.severity = silent
4+
dotnet_diagnostic.CS0618.severity = silent

0 commit comments

Comments
 (0)