[BUG] [typescript-fetch] Parameters with format: date are treated like date-time instead

[michasng]

Description

If I specify a request with a date parameter, with type: string and format: date, then according to relevant documentation, this should be formatted as "2017-07-21", but it is instead formatted as "2017-07-21T17:32:28Z".

openapi-generator version

org.openapi.generator version 6.6.0
using the typescript-fetch generator.

OpenAPI declaration file content or url

parameters:
  name: startDate
  in: query
  schema:
    type: string
    format: date

Generation Details

Steps to reproduce

Simply generate any client with above snippet and look at the output or call the client with any Date object.

Suggest a fix

The generated code does:

queryParameters["startDate"] = (requestParameters.startDate as any).toISOString();

where it should be doing:

queryParameters["startDate"] = requestParameters.startDate.toISOString().split('T')[0];

[michasng]

I have another date parameter defined as required and it generates fine, like this:

queryParameters['startDate'] = (requestParameters.startDate as any).toISOString().substr(0,10);

Either this issue only affects optional parameters or it's something else about the definition.

[michasng]

The underlying issue seems to be a naming conflict.
I had one schema defined with format: date-time in ./timeInterval.yaml#/startDateParam and another one with format: date in ./dateInterval.yaml#/startDateParam.

When I reference the date interval parameter, then it must have resolved the time interval parameter instead:

parameters:
  - $ref: "./parameters/dateInterval.yaml#/startDateParam"

Renaming my time interval parameter to something like startDateTimeParam is a workaround for this issue.
I suppose type names (and not just their path) must be unique.

[spider-hand]

Is there any update on this? I don't have a naming conflict but every properties I defined as date format are recognized as Date object when generating the code.

[spider-hand]

Actually there is a discussion here: #17284