Checking the uniqueness of elements in the ENUM to ensure the correctness of the generated classes #14366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ness of the generated classes Signed-off-by: ShmakovAlexey <year2077@gmail.com>
borsch
reviewed
Jan 2, 2023
| * @return <code>name</code>, uniquely suffixed as necessary. | ||
| */ | ||
| protected String ensureUniqueName(Map<String, Integer> uniqueNames, String name) { | ||
| int count = uniqueNames.containsKey(name) ? uniqueNames.get(name) + 1 : 1; |
There was a problem hiding this comment.
minor
int count = uniqueNames.getOrDefault(name, 0) + 1;
borsch
approved these changes
Jan 2, 2023
|
@shmakovalexey thanks for the PR. Let me try to run some tests this weekend. cc @OpenAPITools/generator-core-team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's another solution for #893
The project [swagger-codegen] (https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java#L324) contains a check for the uniqueness of names, as a result, when using multibyte characters, instead of a list of characters "_", classes are obtained without compilation errors. I think we need to do the same.
In a perfect world, it's the swagger description provider that should add the "x-enum-names" parameter, but in the real world it's very hard to get an external organization to modify their file. Thus, it will be very useful if third-party files are converted into classes that compile without errors.