Skip to content

16840 add jersey2 async methods #16842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nddipiazza-ebay
Copy link

@nddipiazza-ebay nddipiazza-ebay commented Oct 16, 2023

Add Jersey2 Async methods to the auto-generated clients in case people which to use the AsyncInvoker.

@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@karismann
@Zomzog
@lwlee2608
@martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

nddipiazza-ebay and others added 2 commits October 16, 2023 14:38
add async methods to jersey2 openapi generated output.
add async methods to jersey2 openapi generated output.
@nddipiazza-ebay nddipiazza-ebay changed the title 16840 jersey2 async 16840 add jersey2 async methods Oct 16, 2023
@nddipiazza-ebay nddipiazza-ebay marked this pull request as ready for review October 16, 2023 21:12
add async methods to jersey2 openapi generated output.
add async methods to jersey2 openapi generated output.
add async methods to jersey2 openapi generated output.
@wing328
Copy link
Member

wing328 commented Nov 1, 2023

please follow step 3 to update the samples so that the CI can verify the change.

@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 removed this from the 7.2.0 milestone Dec 22, 2023
@nddipiazza-ebay
Copy link
Author

Sorry I do not have my notifications hooked up so I did not see this message! Ahhhh! @wing328

@nddipiazza-ebay
Copy link
Author

I am on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants