Skip to content

[typescript] fix Inversify type checks on CI #20062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dennisameling
Copy link
Contributor

On the current master branch, the "TypeScript clients type checks" check is failing with:

➤ samples/openapi3/client/petstore/typescript/builds/inversify

added 26 packages in 2s
Error: node_modules/@inversifyjs/common/lib/cjs/services/models/LazyServiceIdentifier.d.ts(4,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: node_modules/@inversifyjs/core/lib/cjs/legacyTarget/models/LegacyTargetImpl.d.ts(10,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: Process completed with exit code 2.

Let's enable supportsES6 in the sample testing to get rid of the error.

There is #16187 which will enable es6 across the board by default, but it doesn't seem to be ready just yet.

Tagging the technical committee: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@macjohnny macjohnny merged commit 7bce639 into OpenAPITools:master Nov 8, 2024
16 checks passed
@joscha
Copy link
Contributor

joscha commented Nov 8, 2024

Thank you!

@wing328 wing328 added this to the 7.10.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants