-
-
Notifications
You must be signed in to change notification settings - Fork 7k
To read environment variables while using client generated by open-api-generator #21295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@openapitools/generator-core-maintainers could you take a look at this? |
@canadaduane , @jqr , @wpiekutowski , @farcaller please take a look at my PR... |
please follow step 3 to update the samples |
{{^defaultValue}} | ||
self.{{name}} = None | ||
{{/defaultValue}} | ||
{{/cliOptions}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this part about cliOptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will assign variable with None value if we didn't provide any value to it...
btw, you can use customized templates (e.g.-t via CLI) to customize the mustache templates updated by this PR |
just so we're on the same page, which version of openapi generator did kubernetes python client use to generate the client? |
the python client generator has been completely refactored in openapi generator v7.0.0 (to support only python 3.x) so i don't think the chnage you made here will propagate to the kubernetes python client repo. still you can use customized templates with the changes you applied in this pr |
Summary
This pull request adds support for to read and use environment variables while using kubernetes client generated by open-api-generator
Validation
./mvnw clean package
successfully.