Skip to content

[python] Validate pyproject.toml and fix the pyproject.toml version constraint format #21402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025

Conversation

4c0n
Copy link
Contributor

@4c0n 4c0n commented Jun 10, 2025

Fixes: #21335

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (@cbornet @tomplus @krjakbrjak @fa0311 @multani)

@4c0n 4c0n marked this pull request as ready for review June 11, 2025 08:59
@4c0n 4c0n force-pushed the fix/test-and-fix-pyproject-toml branch from 273c2f5 to e7ac1b0 Compare June 12, 2025 16:20
@4c0n
Copy link
Contributor Author

4c0n commented Jun 13, 2025

Does anyone have any clues as to why mypy is suddenly failing? This does not seem to correlate with the changes this PR is making...

@wing328
Copy link
Member

wing328 commented Jun 16, 2025

agreed it's not related to this PR. i'll take a look

@4c0n 4c0n force-pushed the fix/test-and-fix-pyproject-toml branch from e7ac1b0 to a7cb586 Compare June 17, 2025 07:30
@4c0n
Copy link
Contributor Author

4c0n commented Jun 17, 2025

@wing328 Something like this should fix the issue: #21423 it's not very pretty, but it's probably better than just excluding those lines, which would be another option (using # type: ignore).

@wing328
Copy link
Member

wing328 commented Jun 18, 2025

thanks @4c0n. just merged your fix

@wing328 wing328 merged commit 43e878b into OpenAPITools:master Jun 18, 2025
31 of 36 checks passed
@wing328 wing328 added this to the 7.14.0 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] requires-python invalid value - pyproject.toml
2 participants