Skip to content

Conversation

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Nov 27, 2025

I cloned https://github.com/minio/mc and then just ran make to build a local mc binary which I copied to the init container

@jmthomas jmthomas requested a review from ryanmelt November 27, 2025 16:03
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.17%. Comparing base (7fc0efe) to head (18b1b99).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2577      +/-   ##
==========================================
- Coverage   79.17%   79.17%   -0.01%     
==========================================
  Files         662      662              
  Lines       51305    51305              
  Branches      735      735              
==========================================
- Hits        40622    40619       -3     
- Misses      10603    10606       +3     
  Partials       80       80              
Flag Coverage Δ
python 81.27% <ø> (-0.04%) ⬇️
ruby-api 84.49% <ø> (+0.07%) ⬆️
ruby-backend 82.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link

socket-security bot commented Nov 27, 2025

Copy link
Contributor

@mcosgriff mcosgriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran images, bucket explorer works as expected.

@jmthomas jmthomas merged commit b0e75bb into main Dec 1, 2025
31 checks passed
@jmthomas jmthomas deleted the build_mc branch December 1, 2025 23:40
ryan-pratt pushed a commit that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants