Add lock screen functionality and fix limit session issues #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the session ended the limit was not cleared as it should be (if the auto release flag was set) Allow setting limits when the EV is disabled so they can act as a 'boost'
There was a problem hiding this comment.
Pull Request Overview
This PR adds a lock screen to be displayed when the EVSE is disabled and refactors the limit session handling for proper claim management. Key changes include:
- Introducing LockScreen (header and implementation) with its related rendering and image assets.
- Updating the ScreenManager to transition between lock, charge, and boot screens depending on EVSE state.
- Changing limit session handling in limit.cpp to ensure proper claim release and enabling in default states.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/screens/screen_renderer.{h,cpp} | Added global message buffer functions and declarations shared across screens. |
| src/screens/screen_manager.{h,cpp} | Added support and logic for the lock screen state. |
| src/screens/screen_lock.{h,cpp} | Introduced LockScreen and its rendering functions. |
| src/screens/screen_factory.h | Added new LockScreen case to the factory. |
| src/limit.{h,cpp} | Revised limit session handling and claim management logic. |
| src/lcd_tft.{h,cpp} | Updated message-display calls to use the centralized message functions. |
| src/lcd_static/* | Included static lock screen image assets. |
| src/emonesp.h | Enabled lock screen configuration and default message. |
Comments suppressed due to low confidence (1)
src/limit.cpp:220
- Ensure that this new branch verifying the EVSE's default disabled state is sufficiently covered by tests, so the claim behavior in this case is validated under various scenarios.
else if(EvseState::Disabled == config_default_state() && !_evse->clientHasClaim(EvseClient_OpenEVSE_Limit))
| clear_message_line(y); | ||
| } | ||
|
|
||
| strncpy(_msg[y] + x, msg, LCD_MAX_LEN - x); |
There was a problem hiding this comment.
Consider adding a boundary check for the 'x' parameter before using it as an offset into _msg[y] to prevent a potential buffer overrun when x is not within the valid range (0 to LCD_MAX_LEN).
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a lock screen that activates when the EVSE is disabled, along with enhancements to limit handling to ensure limits are cleared correctly at session end.