-
-
Notifications
You must be signed in to change notification settings - Fork 56
Revert "Temporaly disabling ksp testing" #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: querydsl-7.0
Are you sure you want to change the base?
Conversation
6a44538
to
867f361
Compare
@IceBlizz6 made the issue a separated PR, any assistance you can give, would be appreciated |
I'm looking into it. @velo |
Nevermind, was able to recreate it now i think. |
Seems to be solved by updating hibernate.version |
Ow, that is a problem |
I could try to take a closer look if there are other solutions, but i have some doubts of whether that is even an option. may i ask why we are trying to update to the hibernate beta version? |
Jpa 3.2 support... And that is forcing java 11 out, that is why I decided to start a 7 series branch |
It looks like the error came from just trying to add a Kotlin entity class. Configuration()
.setProperty(AvailableSettings.JAKARTA_JDBC_DRIVER, org.h2.Driver::class.qualifiedName!!)
.setProperty(AvailableSettings.JAKARTA_JDBC_URL, "jdbc:h2:mem:my-database;")
.setProperty(AvailableSettings.HBM2DDL_AUTO, "create-drop")
.setProperty(AvailableSettings.SHOW_SQL, "true")
.addAnnotatedClass(Person::class.java) // Fails only if this line is included
.buildSessionFactory()
.unwrap(EntityManagerFactory::class.java) If this is correct then anyone with a kotlin project on hibernate would be unable to use beta1 anyway. |
867f361
to
2f6bd03
Compare
2f6bd03
to
8e666f1
Compare
This pull request has been marked as stale due to inactivity. |
This pull request has been closed due to inactivity. |
This pull request has been marked as stale due to inactivity. |
This reverts commit 128a207.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## querydsl-7.0 #735 +/- ##
==================================================
+ Coverage 61.06% 70.83% +9.76%
Complexity 84 84
==================================================
Files 828 854 +26
Lines 31905 32239 +334
Branches 3582 3592 +10
==================================================
+ Hits 19482 22835 +3353
+ Misses 11171 8176 -2995
+ Partials 1252 1228 -24 ☔ View full report in Codecov by Sentry. |
This reverts commit 128a207.