Skip to content

Allow users to create database assetstore 'files' #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8 of 11 tasks
manthey opened this issue Oct 20, 2017 · 1 comment
Open
8 of 11 tasks

Allow users to create database assetstore 'files' #43

manthey opened this issue Oct 20, 2017 · 1 comment

Comments

@manthey
Copy link
Contributor

manthey commented Oct 20, 2017

Allow users to create database files.

Currently, to create a file an admin must first create an assetstore which references a specific database. The assetstore import function is used to create a Girder file that references a specific table/collection in the database with a default filter, fields, sort, limit, and format.

In addition to this, anywhere uploads are allowed we could alternately allow adding a database file.

There are a number of features that would be desired to implement this. One a basic implementation is available, some of these can become their own issues.

  • For the database assetstore plugin, add a settings page. This would
    • have a checkbox to enable user file creation
    • optionally allow any user with write privilege to add a file
    • have a list of acls which specify which users are allowed to create files
    • for any given acl (and the general case), allow a regex to validate the database uri. This can be used to limit the hosts, database types, etc.
  • Internally add a special assetstore ID that is used for user-defined files. This should be a constant so that if the plugin is disabled and reenabled no changes need to be made.
  • Add button on upload dialogs or where upload buttons occur to switch to the create database file dialog
  • Add create database file dialog. This is a similar to the current assetstore import functionality, but needs to ask for a database uri (and does not need to have the destination fields, since the upload button already has this as a context), and would only allow one table/collection at a time.
  • Add a button to check access to the database uri (both in the file dialog and the create assetstore panel). This verifies that the database is reachable at the time the user is adding the file (it can be optional)
  • Add a query builder to help construct fields, sort, filters. This would not support general functions at this time. See the query builder that was added to Minerva for an example of how to do this.
  • Show the current default limit (try to report what it might be based on the current data with the current filters)
@manthey
Copy link
Contributor Author

manthey commented Aug 31, 2018

There is a WIP branch that allows a user on the web client to edit files after they have been uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant