Tax remove for guest vwith validate vat id via VIES

[DegrizNet]

Hello everybody!

I just cam across some old modul my client use to remove tax form product on validated vat number. Problem was that it removed vat in quote but when creating order it added tax back to order. This was problem just for guest. I do not know if code somehow changed or we missed this problem for couple of years. :)

So this is the code I need to test it but I am not sure this is the right way to do it.. is there a better way?

    <frontend>
        <events>
            <sales_quote_collect_totals_before>
                <observers>
                    <degriz_davcnastopnja_cart_add>
                        <class>degriz_davcnastopnja/observer</class>
                        <method>changeTaxRate</method>
                    </degriz_davcnastopnja_cart_add>
                </observers>
            </sales_quote_collect_totals_before>
            <sales_model_service_quote_submit_before>
                <observers>
                    <degriz_davcnastopnja_order_add>
                        <class>degriz_davcnastopnja/observer</class>
                        <method>changeTaxRateOnOrder</method>
                    </degriz_davcnastopnja_order_add>
                </observers>
            </sales_model_service_quote_submit_before>
        </events>
    </frontend>

<?php
class Degriz_DavcnaStopnja_Model_Observer
{
    public function changeTaxRate($observer = null)
    {
        $store = Mage::app()->getStore();
        $helper = Mage::helper('degriz_davcnastopnja');
        
        if($helper->isModuleEnabled($store) == false) {
            return;
        }
        
        $quote = $observer->getQuote();
        $billingAddress = $quote->getBillingAddress();
        
        $this->_validateVatForQuote($billingAddress);
    }
    
    public function changeTaxRateOnOrder($observer)
    {
        $quote = $observer->getQuote();
        $store = $quote->getStore();
        $helper = Mage::helper('degriz_davcnastopnja');
        
        if (!$helper->isModuleEnabled($store)) {
            return;
        }
        
        $billingAddress = $quote->getBillingAddress();
        
        $this->_validateVatForQuote($billingAddress);
    
        $quote->setTotalsCollectedFlag(false);
        $quote->collectTotals();
    }
    

    protected function _validateVatForQuote($address)
    {
        if (!$address instanceof Mage_Sales_Model_Quote_Address) {
            return;
        }
        
        $country = $address->getCountryId();
        $vatId = trim($address->getVatId());
        
        if (!$vatId || !Mage::helper('core')->isCountryInEU($country)) {
            return;
        }
        
        $result = Mage::helper('customer')->checkVatNumber($country, $vatId);
        
        if ($result->getIsValid()) {
           
            $taxFreeGroupId = Mage::getStoreConfig('degriz_davcnastopnja/settings/tax_free_group');
            if (!$taxFreeGroupId) {
                $taxFreeGroupId = 3;
            }
            
            $quote = $address->getQuote();
            
            $quote->setCustomerGroupId($taxFreeGroupId);
        
            $customer = $quote->getCustomer();
            if ($customer && $customer->getId()) {
                $customer->setGroupId($taxFreeGroupId);
                try {
                    $customer->save();
                } catch (Exception $e) {
                    Mage::logException($e);
                }
            }
 
            $quote->setTotalsCollectedFlag(false); 
        }
    }
}

[addison74]

Copilot will help you for sure. Initiate a chat in your native language about this request, cover all the issues, paste the code, create a module, etc.

[kiatng]

Even though Copilot + VS Code has improved a lot, I find it is too eager to code and not as clever as Cursor.

[DegrizNet]

Yes, I also prefer cursor. Ai went wrong way doing this.. like changing tax on order and items.. i think this code should work. Will just do more test.