Skip to content

PHPUnit: added/updated tests #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

PHPUnit: added/updated tests #4758

wants to merge 42 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Apr 19, 2025 •
edited
Loading

Description (*)

Added ~100 tests and updated all existing ones.

  • added all tests from Replace Zend_Validation #4612 and improved them (there will be some errors now)
  • split tests into testsuites
  • removed duplicated code
  • some cleanup (use static methods, ...)

Related Pull Requests

Questions or comments

To test controllers i have added this to composer.json

    "autoload-dev": {
        "classmap": ["app/code/*/*/*/controllers"],

Should we use it for core too? Ping @justinbeaty.

@github-actions github-actions bot added environment Component: Core Relates to Mage_Core Component: Cms Relates to Mage_Cms labels Apr 19, 2025
@github-actions github-actions bot added Component: Reports Relates to Mage_Reports Component: Adminhtml Relates to Mage_Adminhtml Component: Index Relates to Mage_Index composer Relates to composer.json php-cs-fixer phpunit rector labels Apr 19, 2025
@sreichel sreichel changed the title Phpunit pre symfony PHPUnit: added/updated tests Apr 19, 2025
addison74
addison74 previously approved these changes Apr 19, 2025
View reviewed changes
@sreichel sreichel mentioned this pull request Apr 20, 2025
Closed
@sreichel sreichel mentioned this pull request Apr 23, 2025
Draft
3 tasks
@github-actions github-actions bot added the git label Apr 25, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
6 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Index Relates to Mage_Index Component: Reports Relates to Mage_Reports composer Relates to composer.json environment git php-cs-fixer phpunit rector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @addison74