Skip to content

Fix CMake compatibility warnings #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CMake compatibility warnings #1907

wants to merge 6 commits into from

Conversation

@3manifold
Copy link

@3manifold 3manifold commented Jul 21, 2025 •
edited
Loading

#1905 has to be merged first to fix the CI.

resolves #1899

@3manifold 3manifold mentioned this pull request Jul 21, 2025
Open
@3manifold 3manifold force-pushed the update-submodules branch from 156d7d4 to 4f81649 Compare July 21, 2025 10:27
@3manifold 3manifold changed the title Check CMake warnings Fix CMake compatibility warnings Jul 21, 2025
@Daviey
Copy link

Daviey commented Oct 9, 2025

Thanks for working on this. This issue is affecting NixOS users (NixOS/nixpkgs#450258) and will likely impact other distributions as they upgrade to CMake 4.x.

I'll create a patch for NixOS inspired by your CMake version updates here. Looking forward to this being merged upstream so we can remove our patch.

Daviey added a commit to Daviey/nixpkgs that referenced this pull request Oct 9, 2025
@Daviey
ctranslate2: fix CMake 4 compatibility with patch file
5164027 
Adds a patch file to update cmake_minimum_required from 3.7 to 3.10 in
the main CMakeLists.txt files. Keeps the existing postPatch for vendored
dependencies since those are git submodules that can't be easily patched
with patch files.

CMake 4 doesn't support versions older than 3.5, and versions between
3.5-3.10 are deprecated.

Upstream is working on a similar fix in OpenNMT/CTranslate2#1907

Fixes: NixOS#450258
Signed-off-by: Dave Walker <dave@daviey.com>
@Daviey Daviey mentioned this pull request Oct 9, 2025
Draft
@3manifold 3manifold marked this pull request as ready for review October 9, 2025 14:26
@3manifold
Copy link
Author

3manifold commented Oct 9, 2025 •
edited
Loading

Thanks for working on this. This issue is affecting NixOS users (NixOS/nixpkgs#450258) and will likely impact other distributions as they upgrade to CMake 4.x.

I'll create a patch for NixOS inspired by your CMake version updates here. Looking forward to this being merged upstream so we can remove our patch.

Hi @Daviey , in order to make commits/changes more meaningful, keep this in mind:

#1905 has to be merged first to fix the CI.

gruenich
gruenich reviewed Oct 9, 2025
View reviewed changes
@3manifold
Copy link
Author

CI fails because a submodule of a submodule (i.e. ruy->cpuinfo) is outdated. I submitted a fix here google/ruy#367 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gruenich gruenich gruenich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatibility with CMake < 3.5 has been removed from CMake.

3 participants

@3manifold @Daviey @gruenich