Added saving of best checkpoint during early stopping#1859
Open
sugeeth14 wants to merge 4 commits intoOpenNMT:masterfrom
Open
Added saving of best checkpoint during early stopping#1859sugeeth14 wants to merge 4 commits intoOpenNMT:masterfrom
sugeeth14 wants to merge 4 commits intoOpenNMT:masterfrom
Conversation
Member
|
Not sure why you apply this logic only when early_stopped is triggered. |
2.Upated logic to add config containing info about best checkpoint 3.fixed case when keep_checkpoint < early_stopping.
Author
|
This is the best I could think of
Sorry if this is getting long this is the best I could think to cover all cases. Suggestions welcome. Thanks |
Author
|
@francoishernandez any update on this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With reference to the issue here #1856 and the pull request discussion here #1858 . Best checkpoint will now not be removed when early stopping happens.