Fix error to load data at the correct position when resuming from a checkpoint#2520
Open
PC91 wants to merge 1 commit intoOpenNMT:masterfrom
Open
Fix error to load data at the correct position when resuming from a checkpoint#2520PC91 wants to merge 1 commit intoOpenNMT:masterfrom
PC91 wants to merge 1 commit intoOpenNMT:masterfrom
Conversation
cd4d637 to
3c4b7b7
Compare
Member
|
This is doing the same thing as what is described here: #2006 (comment) |
3c4b7b7 to
0a06542
Compare
0a06542 to
874efcc
Compare
d191392 to
e2093e2
Compare
e2093e2 to
b422cfc
Compare
Contributor
Author
Thanks @vince62s! The code is updated. Could you have a look and merge to the main code base ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a mechanism to resume a training from the positions in corpora. The idea is to use a cursor for each corpus and save its text line (the batch variable
cid_line_number) to the saved checkpoint file.The following features are implemented:
resume_from_corpora: whenTrue, the training will try to resume from the last text line of each corpus. Otherwise, the training will resume from the beginning of all corpora.cid_line_numberto get the text line number directly from theexfile_openfunction.The following scenarios are tested:
resume_from_corpora=Trueresume_from_corpora=False (resume from beginning.)