Cost estimation #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
table of cost estimations can be found in cost_tables.txt |
fgfuchs
requested changes
Apr 25, 2025
Member
fgfuchs
left a comment
fgfuchs
left a comment
There was a problem hiding this comment.
- First, this PR can not be merged automatically. -> 2.
- Your branch must branch out of the main branch of the repository you merge it to! Not like this: Screenshot 2025-04-25 at 08-36-38 Network Graph · OpenQuantumComputing_LogicalXMixer · GitHub
- This script currently reads more like a prototype or proof of concept than maintainable code. Some key issues:
- No modular structure (e.g., classes or reusable components).
- Lacks docstrings, type hints, and consistent naming.
- Contains deeply nested logic, repeated patterns, and magic constants.
- Overall hard to read and extend.
I suggest a refactor with clearer abstractions, documentation, and separation of concerns to improve clarity and reusability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for brute-forced solutions, including cost estimations.