Fix: Multiply filter change event (signal) triggers when filter panel gets shown (#610)

* Fix: Filtering was updated without changed.

Please retest and check whether this fix has any side-effects which are not detected during this change. If no side-effects - the overall behavior is improved (performance)

* cleaned code and formated

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: aiAdrian

src/app/services/analytics/origin-destination/components/origin-destination.component.ts

@@ -1,5 +1,5 @@
 import {OriginDestination, OriginDestinationService} from "./origin-destination.service";
-import {Component, ElementRef, OnDestroy, OnInit, ViewChild} from "@angular/core";
+import {AfterViewInit, Component, ElementRef, OnDestroy, OnInit, ViewChild} from "@angular/core";
 import * as d3 from "d3";
 
 import {Subject, takeUntil} from "rxjs";
@@ -26,7 +26,7 @@ type ColorSetName = "red" | "blue" | "orange" | "gray";
   templateUrl: "./origin-destination.component.html",
   styleUrls: ["./origin-destination.component.scss"],
 })
-export class OriginDestinationComponent implements OnInit, OnDestroy {
+export class OriginDestinationComponent implements OnInit, AfterViewInit, OnDestroy {
   @ViewChild("div") divRef: ElementRef;
 
   private readonly destroyed$ = new Subject<void>();
@@ -54,11 +54,17 @@ export class OriginDestinationComponent implements OnInit, OnDestroy {
 
   private cellSize: number = 30;
 
+  private isReadyToRender = false;
+
   private extractNumericODValues(odList: OriginDestination[], field: FieldName): number[] {
     return odList.filter((od) => od["found"]).map((od) => od[field]);
   }
 
   private renderView() {
+    if (!this.isReadyToRender) {
+      return;
+    }
+
     const nodes = this.originDestinationService.getODOutputNodes();
     const nodeNames = nodes.map((node) => ({
       shortName: node.getBetriebspunktName(),
@@ -78,9 +84,6 @@ export class OriginDestinationComponent implements OnInit, OnDestroy {
 
   // Compute the matrix (expensive) and render the default view.
   ngOnInit(): void {
-    this.loadMatrixData();
-    this.renderView();
-
     this.uiInteractionService.zoomInObservable
       .pipe(takeUntil(this.destroyed$))
       .subscribe((zoomCenter: Vec2D) => this.controller.zoomIn(zoomCenter));
@@ -101,7 +104,17 @@ export class OriginDestinationComponent implements OnInit, OnDestroy {
     });
   }
 
+  ngAfterViewInit(): void {
+    this.isReadyToRender = true;
+    this.loadMatrixData();
+    this.renderView();
+  }
+
   private loadMatrixData(): void {
+    if (!this.isReadyToRender) {
+      return;
+    }
+
     // Load raw OD data and ensure diagonal entries exist (only once on init)
     this.matrixData = this.originDestinationService.originDestinationData();
 

src/app/view/editor-filter-view/editor-filter-view.component.ts

@@ -49,7 +49,6 @@ export class EditorFilterViewComponent implements OnInit, OnDestroy {
   ) {
     this.activeFilterName = undefined;
     this.activeEditFilterSettingId = undefined;
-    this.filterService.filterChanged();
     this.filterService.filter.pipe(takeUntil(this.destroyed)).subscribe(() => {
       this.updateFilterData();
     });

src/app/view/editor-filter-view/filterable-label-filter/filterable-label-filter.component.ts

@@ -41,8 +41,6 @@ export class FilterableLabelFilterComponent implements OnInit, OnDestroy {
         this.translateComponentLabelRef(),
       );
     });
-
-    this.filterService.filterChanged();
   }
 
   ngOnDestroy(): void {