feat: adds global nodes management form #613
Conversation
This commit addresses issue: OpenRailAssociation/osrd#13292 Details: - Adds new component GlobalNodesManagementComponent in app/view/editor-edit-tools-view-component - The new component controls the isCollapsed state of the nodes - Adds EN and FR translations for the new component - Adds the new component to the existing EditorEditToolsViewComponent panel
louisgreiner
left a comment
louisgreiner
left a comment
There was a problem hiding this comment.
Looks very nice and the search bar is really good.
I wonder if we could ask user's confirmation when checking the box for all the nodes at once? This component already exists in the application I think, we can reuse it.
PS: you should make your PR into mrd/new-nodes-management-system I think, we use this as feature branch
...ditor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.ts
Outdated
Show resolved
Hide resolved
...tor-edit-tools-view-component/global-nodes-management/global-nodes-management.component.html
Outdated
Show resolved
Hide resolved
This commit handles various feedbacks from reviewers on PR: #613 Details: - Fixes some FR translations - Renames "visible nodes" as "matching nodes" - Caches the matching nodes array - Adds a confirmation modal when clicking the global checkbox
jacomyal
changed the base branch from
main
to
mrd/new-nodes-management-system
louisgreiner
left a comment
louisgreiner
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Early approve but should wait for the other features to be merged first
| standalone: true, | ||
| imports: [FormsModule, SbbCheckbox, SbbInput, I18nModule], |
There was a problem hiding this comment.
I'm not familiar with standalone components, but what is the pros and cons of defining the imports here? Since all of them are already part of src/app.module.ts?
Also, all of the other components are not defined that way
What do you think @emersion?
| "nodes": "Nodes" | ||
| } | ||
| }, | ||
| "nodes-search-placeholder": "Search for names or trigrams", |
There was a problem hiding this comment.
Nit: "trigram" (and "BetriebspunktName") will be soon renamed "Short Name" all across the application
Description
This PR depends on PR #554. It should only be merged once #554 is merged as well.
This PR adds a new block in the "Edit" side panel, to allow controlling the
isCollapsedstate of the nodes.This form displays:
isCollapsedstateIssues
Checklist
documentation/