Skip to content

Conversation

@aiAdrian
Copy link
Contributor

@aiAdrian aiAdrian commented Nov 17, 2025

…med during the one-way feature implementation.

Description

The migration of the third-party import was not correctly performed during the one-way feature implementation : Issue fixed

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

…med during the one-way feature implementation.
@aiAdrian aiAdrian added this to the 2.10 milestone Nov 17, 2025
@aiAdrian aiAdrian self-assigned this Nov 17, 2025
@aiAdrian aiAdrian added the bug Something isn't working label Nov 17, 2025
@aiAdrian aiAdrian linked an issue Nov 17, 2025 that may be closed by this pull request
3 tasks
@louisgreiner
Copy link
Contributor

I'm not sure to understand how what's the purpose of detectNetzgrafikJSON3rdParty() and how this is triggered, if you could provide a short video clip?

Otherwise, nice spot, we've forgotten this one

@aiAdrian
Copy link
Contributor Author

aiAdrian commented Nov 18, 2025

We have an data conertor at SBB which transforms internal data into the Netzgrafik. The tool will be open sourced as soon as possible, but it has still a few bugs and not yet solved stuff.

What it does: It generates all nodes and write them into a json. Then it generates all trainrun elements and its sections. But the node doesn't have the ports set. As soon as you import a json without ports, Nerzgrafik-Editor detects it and tries to import the JSON as 3rd party. During importing it recalculates the port routing and all other missing elements and updates as well trainrun categories whenever there are new ones. What you get is a complete Netzgrafik which can further edited or just used for visualisation...

Our convertor detects frequency and round-trips based on a heuristic from common timetable.

Copy link
Contributor

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, lgtm then :)

@aiAdrian aiAdrian merged commit 70b46e3 into main Nov 18, 2025
6 checks passed
@aiAdrian aiAdrian deleted the 619-bug-3rd-party-json-import-is-broken branch November 18, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 3rd party JSON import is broken

3 participants