Open
Conversation
Modcods not in Table 5 and Table 12 have been removed from the cfg creation case statements. Here are the specifics. 1) Short frames do not use the 9/10 rate, so that rate was removed for all short frame entries. 2) 8PSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries. 3) 16APSK uses 6 of the 11 rates. Unused rates were removed from both short and normal frame entries. 4) 32APSK uses 5 of the 11 rates. Unused rates were removed from both short and normal frame entries.
Abraxas3d
added
documentation
MustBeArt
reviewed
Oct 21, 2022
MustBeArt
left a comment
MustBeArt
left a comment
There was a problem hiding this comment.
I think all these changes are right.
Maybe we should do something more hardware-friendly in the case where an unknown mode word is received. Default to a valid MODCOD instead of failing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings all!
Modcods not in Table 5 and Table 12 have been removed from the cfg creation case statements. Here are the specifics.